users@jersey.java.net

Re: [Jersey] HTTPSProperties issue

From: Pavel Bucek <Pavel.Bucek_at_Sun.COM>
Date: Thu, 15 Apr 2010 21:44:07 +0200

there already is this ctor:

    /**
     * Construct with a {_at_link HostnameVerifier} and a {_at_link SSLContext}
     * constructed using <code>SSLContext.getInstance("SSL")</code>.
     *
     * @param hv the HostnameVerifier.
     * @throws java.security.NoSuchAlgorithmException if the SSLContext
could not
     * be created.
     */
    public HTTPSProperties(HostnameVerifier hv) throws
NoSuchAlgorithmException {
        this (hv, SSLContext.getInstance("SSL"));
    }

I guess this is what you are writing about.. (and it is there from the
beginning, maybe you just overlooked it..)

btw patch you suggested is already committed:
https://jersey.dev.java.net/servlets/ReadMsg?list=commits&msgNo=3520

Regards,
Pavel

John Calcote wrote:
> Pavel,
>
> Just a thought, but there are several constructors for HTTPSProperties
> - the default constructor accepts no host verifier, and uses the
> default SSLContext. Might be nice if there were a constructor that
> accepted only a host verifier, and used the default SSLContext. But
> perhaps there are no use cases for that sort of thing anyway...
>
> Thanks for looking into it.
>
> Regards,
> John
>
> On 4/15/2010 3:21 AM, Pavel Bucek wrote:
>>
>> Hello John,
>>
>> I agree, you should not be able to set null SSLContext.
>>
>> I'll update javadoc and code, constructor will now throw
>> IllegalArgumentException when you try to do that.
>>
>> Thanks,
>> Pavel
>>
>>
>> John Calcote wrote:
>>> Hi Paul,
>>>
>>> Just ran into a usability bug. Thought I'd drop you a note about it.
>>>
>>> When I created my HTTPProperties object, I wanted to supply a host
>>> name verifier, and possibly an ssl context. I assumed I could pass a
>>> null ssl context, meaning that the constructor would then use a
>>> default ssl context. However the HTTPSProperties constructor simply
>>> stores the null, and then crashes later. Might be nice to either
>>> document the fact that null is not acceptable in this ctor, or
>>> change the ctor to accept null and then build a default ssl context.
>>>
>>> Thanks,
>>> John
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: users-unsubscribe_at_jersey.dev.java.net
>>> For additional commands, e-mail: users-help_at_jersey.dev.java.net
>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: users-unsubscribe_at_jersey.dev.java.net
>> For additional commands, e-mail: users-help_at_jersey.dev.java.net
>>
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe_at_jersey.dev.java.net
> For additional commands, e-mail: users-help_at_jersey.dev.java.net
>