On Dec 15, 2009, at 2:44 PM, Yoryos wrote:
> There is a logical bug:
>
> Try to add a:
> IncludeViewResource model again: ${it} at the end of the
> include.jsp. The it is not the expected one. I would expect the one
> of IncludeViewResource but as we've included the TwoResource class,
> the it has been overwritten by it's model witch is the string
> 'TwoResource'
>
Nice catch, this requires a simple modification to the
RequestDispatcherWrapper:
public void forward(ServletRequest req, ServletResponse rsp)
throws ServletException, IOException {
ResolvedViewable rv =
(ResolvedViewable
)hc.getProperties().get("com.sun.jersey.spi.template.ResolvedViewable");
Object oldIt = req.getAttribute("it");
req.setAttribute("httpContext", hc);
req.setAttribute("resolvingClass", rv.getResolvingClass());
req.setAttribute("it", it);
req.setAttribute("_basePath", basePath);
req.setAttribute("_request", req);
req.setAttribute("_response", rsp);
d.forward(req,rsp);
if (oldIt != null)
req.setAttribute("it", oldIt);
}
> I can't think how could c:import work out of the box without named
> model. I'll try to play with a jsp tag that will replace the model
> in each include. That should work (I hope :-) ).
>
Even with a named model the same issue could have occurred if two
views independently use the same name.
Paul.
>
> On Tue, Dec 15, 2009 at 15:08, Paul Sandoz <Paul.Sandoz_at_sun.com>
> wrote:
>
> On Dec 15, 2009, at 12:31 PM, Paul Sandoz wrote:
>
>> On Dec 15, 2009, at 12:06 PM, Paul Sandoz wrote:
>>>>
>>>> OK. I have just played around with your sample and if i do not
>>>> register your ExtendedJSPTemplateProcessor and modify Jersey's
>>>> RequestDispatcherWrapper such that the include methods is
>>>> implemented as follows:
>>>>
>>>> public void include(ServletRequest req, ServletResponse rsp)
>>>> throws ServletException, IOException {
>>>> ResolvedViewable rv =
>>>> (ResolvedViewable
>>>> )hc
>>>> .getProperties
>>>> ().get("com.sun.jersey.spi.template.ResolvedViewable");
>>>>
>>>> req.setAttribute("httpContext", hc);
>>>> req.setAttribute("resolvingClass", rv.getResolvingClass());
>>>> req.setAttribute("it", it);
>>>> req.setAttribute("_basePath", basePath);
>>>> req.setAttribute("_request", req);
>>>> req.setAttribute("_response", rsp);
>>>> d.include(req,rsp);
>>>> }
>>>>
>>>
>>> Clarification: the above does not actually require any
>>> modification because Jersey's JSPTemplateProcessor always calls
>>> the forward on the dispatcher. Thus some tweaks to the
>>> ServletContainer.filter method may be all that is required.
>>>
>>
>> After debugging, i observed that the
>> ExtendedServletContainer.doFilter is never called for includes from
>> views. Thus there is something more fundamental going on. Since the
>> JSPTemplateProcessor calls forward then perhaps after that it is
>> not possible to include using the JSP include tag?
>>
>
> Doh! i forgot to include the following statement in the JSP file:
>
> <%@ taglib uri="http://java.sun.com/jsp/jstl/core" prefix="c" %>
>
> Now everything works as i would expect.
>
> Attached is a modification of your example that uses Jersey's
> unmodified JSPTemplateProcessor and RequestDispatcherWrapper.
>
> Paul.
>
>
>
>
>> In any case from what i can tell one does not have to modify
>> Viewable to get equivalent behavior for view inclusion as in the
>> example you provide. But, to get re-entrant inclusion will require
>> a little more head scratching to work out and still may require a
>> custom tag.
>>
>> Paul.
>>
>
>
>