On Dec 18, 2008, at 4:16 PM, Gili wrote:
>
> Sounds good to me. I assume you can make this change on your
> end? or do
> you need me to submit a new patch?
>
I can do it. I will remember because i wrote it down in the issue :-)
Paul.
> Gili
>
> Paul Sandoz (via Nabble) wrote:
>
> > Hi Gili,
> >
> > This patch looks good. Just one thing i would propose differently: I
> > think we should mark getBuilder as deprecated and have a new method
> > getUriBuilder() that we don't break existing code.
> >
> > Paul.
> >
> > On Dec 17, 2008, at 8:28 PM, Gili wrote:
> >
> > >
> > > I posted a patch here:
> > https://jersey.dev.java.net/issues/show_bug.cgi?id=168
> > >
> > > Feel free to take as little or as much of it as you want (that
> is,
> > > you can
> > > ignore changes to WebResource.getBuilder() if you want).
> > >
> > > Here are the changes I ended up making:
> > >
> > > - WebResource.Builder's constructor no longer takes a URI, it
> just
> > > reads the
> > > value from the enclosing class
> > > - WebResource.getBuilder() renamed to WebResource.getUriBuilder()
> > > - Added WebResource.getRequestBuilder()
> > > - Same for AsyncWebResource
> > > - Modified two affected tests
> > >
> > > Gili
> > > --
> > > View this message in context:
> > http://n2.nabble.com/WebResource.getRequestBuilder%28%29-tp1668929p1669358.html
> > > Sent from the Jersey mailing list archive at Nabble.com.
> > >
> > >
> > >
> ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: users-unsubscribe@...
> > <http://n2.nabble.com/user/SendEmail.jtp?type=node&node=1672722&i=0>
> > > For additional commands, e-mail: users-help@...
> > <http://n2.nabble.com/user/SendEmail.jtp?type=node&node=1672722&i=1>
> > >
> >
> >
> >
> ---------------------------------------------------------------------
> > To unsubscribe, e-mail: users-unsubscribe@...
> > <http://n2.nabble.com/user/SendEmail.jtp?type=node&node=1672722&i=2>
> > For additional commands, e-mail: users-help@...
> > <http://n2.nabble.com/user/SendEmail.jtp?type=node&node=1672722&i=3>
> >
> >
> >
> >
> ------------------------------------------------------------------------
> > This email is a reply to your post @
> > http://n2.nabble.com/WebResource.getRequestBuilder%28%29-tp1668929p1672722.html
> > You can reply by email or by visting the link above.
> >
>
> View this message in context: Re: [Jersey]
> WebResource.getRequestBuilder()
> Sent from the Jersey mailing list archive at Nabble.com.