On Sun, 2008-07-27 at 18:17 +0200, Paul Sandoz wrote:
> Martin Grotzke wrote:
> > Hi,
> >
> > really great work, thanx!
> >
>
> I second that, nice work Jakub.
>
>
> > Just two things I want to address:
> >
> > 1) Two tests seems to fail in jersey-tests, so I can install
> > trunk/jersey via "mvn -Dmaven.test.skip=true install" but not with "mvn
> > install".
> >
>
> I seem to recall those tests are related to entity round tripping and
> only fail for JDK 1.6. I have not had time to investigate why. Feel free
> to modify/commit the failing test and prefix the method name with
> "ignored" as Jakub has done for some others.
I changed these tests, so that they are ignored for now:
EntityTypesTest.testFormRepresentation
EntityTypesTest.testDOMSourceRepresentation
Cheers,
Martin
>
>
> > 2) I noticed that the module "generate-wadl" in jersey/samples/pom.xml
> > was removed. The dependency on jersey-project was wrong, so that
> > generate-wadl could not be built. I changed the dependency to
> > jersey-server, so that the generate-wadl sample now builds correctly.
> > If this was the reason why it was removed from samples/pom.xml it can be
> > added again.
> >
>
> Sure, do you want to add it?
>
> Paul.