Doh, we've been actively avoiding the dependency on jersey-core. Any
chance of copying the service loader into oauth-signature for now --
until Java 6 is supported?
On Mon, 2009-05-25 at 18:52 +0200, Jakub Podlesak wrote:
> On Mon, May 25, 2009 at 09:43:45AM -0700, Paul C. Bryan wrote:
> > Are you going to copy into the oauth-signature library? One of our
> > objectives was to limit the dependencies that that library has to Java
> > SE only.
>
> Oops, i was about to add a new dependency to jersey-core
> Do you mind having this dependency in oauth-signature?
> It is just about 288KB jar.
>
> ~Jakub
>
> >
> > On Mon, 2009-05-25 at 18:26 +0200, Jakub Podlesak wrote:
> > > On Mon, May 25, 2009 at 06:24:08PM +0200, Jakub Podlesak wrote:
> > > > On Mon, May 25, 2009 at 07:44:08AM -0700, Paul C. Bryan wrote:
> > > > > Thanks. Merging into trunk. Any special considerations for Hudson?
> > > >
> > > > Hi Paul,
> > > >
> > > > only that we are still using jdk1.5 for building, and i see your
> > > > oauth-signature/client/server/tests require 1.6. Do you use any 1.6 specific features
> > > > in your code? If yes, we need to find out, how to workaround that
> > > > in 1.5.
> > >
> > > Now i see: java.util.ServiceLoader it is, we can probably use the internal one.
> > > Let me give it a try and get back to you...
> > >
> > > ~Jakub
> > >
> > > >
> > > > ~Jakub
> > > >
> > > > >
> > > > > On Mon, 2009-05-25 at 07:35 +0200, Paul Sandoz wrote:
> > > > > > Hi Paul,
> > > > > >
> > > > > > Please feel free to commit to the trunk. I am traveling today and do
> > > > > > not want to hold you up, i will try and look at the code this week
> > > > > > (but J1 takes priority).
> > > > > >
> > > > > > Jakub, if you have time could you be so kind to review the pom files?
> > > > > >
> > > > > >
> > > > > > On May 25, 2009, at 6:24 AM, Paul C. Bryan wrote:
> > > > > >
> > > > > > > Hi Devs:
> > > > > > >
> > > > > > > The Jersey-OAuth libraries are now code-complete. Included are unit
> > > > > > > tests for the oauth-signature library, and integration tests for
> > > > > > > oauth-client and oauth-server classes. I think it's now in an
> > > > > > > appropriate state that I'd like to propose to merge from the
> > > > > > > oauth-extensions branch into trunk. Please review and let me know if
> > > > > > > this can go ahead.
> > > > > > >
> > > > > > > Paul
> > > > > > >
> > > > > > > P.S. Since I'm still a relative Maven newbie, one area in particular
> > > > > > > I'd
> > > > > > > like to ask for particular scrutiny is the case of the "oauth-tests"
> > > > > > > integration test module. I wanted this to live in the jersey-oauth
> > > > > > > pom,
> > > > > > > but it created a cyclic dependency. I also wanted the oauth-tests
> > > > > > > packaging be pom (to prevent generation of a jar file) but I'm not
> > > > > > > clear
> > > > > > > on how to set the goals to still compile and execute the tests without
> > > > > > > jar packaging. It works now; it just adds cruft of creating an empty
> > > > > > > jar
> > > > > > > file.
> > > > > > >
> > > > > >
> > > > > > That is OK, there are Jersey integration tests in a separate jar
> > > > > > module as well.
> > > > > >
> > > > > > Paul.
> > > > > >
> > > > > > ---------------------------------------------------------------------
> > > > > > To unsubscribe, e-mail: dev-unsubscribe_at_jersey.dev.java.net
> > > > > > For additional commands, e-mail: dev-help_at_jersey.dev.java.net
> > > > > >
> > > > >
> > > > >
> > > > > ---------------------------------------------------------------------
> > > > > To unsubscribe, e-mail: dev-unsubscribe_at_jersey.dev.java.net
> > > > > For additional commands, e-mail: dev-help_at_jersey.dev.java.net
> > > > >
> > > >
> > > > ---------------------------------------------------------------------
> > > > To unsubscribe, e-mail: dev-unsubscribe_at_jersey.dev.java.net
> > > > For additional commands, e-mail: dev-help_at_jersey.dev.java.net
> > > >
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscribe_at_jersey.dev.java.net
> > > For additional commands, e-mail: dev-help_at_jersey.dev.java.net
> > >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe_at_jersey.dev.java.net
> > For additional commands, e-mail: dev-help_at_jersey.dev.java.net
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_jersey.dev.java.net
> For additional commands, e-mail: dev-help_at_jersey.dev.java.net
>