bhaktimehta_at_dev.java.net wrote:
> File [changed]: Messages.java
> Url: https://jaxb2-sources.dev.java.net/source/browse/jaxb2-sources/jaxb-ri/xjc/src/com/sun/tools/jxc/apt/Messages.java?r1=1.1&r2=1.2
> Delta lines: +1 -1
> -------------------
> --- Messages.java 15 Apr 2005 20:08:50 -0000 1.1
> +++ Messages.java 5 May 2005 23:45:16 -0000 1.2
> @@ -14,7 +14,7 @@
> NO_FILE_SPECIFIED, // 0 args
> ;
>
> - private static final ResourceBundle rb = ResourceBundle.getBundle(Messages.class.getName());
> + private static final ResourceBundle rb = ResourceBundle.getBundle("com.sun.tools.jxc.apt.MessageBundle");
I'm sorry, but I don't like this. I avoided hard-coding package name
into the class, so that I can easily copy one Message class into another
package and use it. This is error prone.
We should really do:
ResourceBundle.getBundle(Messages.class.getName()+"Bundle");
We can split the work to clean this up, but I think we should fix them.
--
Kohsuke Kawaguchi
Sun Microsystems kohsuke.kawaguchi_at_sun.com