Re: Significant, not discussed changes on master (was: Re: MOJARRA_2_3X_ROLLING branch has been created)

From: arjan tijms <>
Date: Fri, 17 Feb 2017 22:56:12 +0100


Sorry if the changes took anyone by surprise. The move to a Maven structure
was already started a great while ago (originally started by Manfred then
continued by me). I was told however to hold of with making a full switch
over until the 2.3 branch was made and the trunk was re-opened again.

So when the trunk did indeed opened I figured this was the right thing to
do, and now was a specifically good time for it, since it's a bit of the
calm period so to speak for the trunk.

In general, having a kind of mixup between various project types/build
systems, such as Ant and Maven in this case, proved to be very confusing.
We have all experienced this. It took me personally quit a bit of time to
be able to build the Mojarra project and run the tests. Bauke experienced
the same thing, and recently Thomas mentioned it too, again.

With OmniFaces we took the same step btw, moving from Ant to Maven, but
this was of course much easier since the project was so much smaller.

Next to the big change of moving over the files to the Maven default
locations, I also started fixing some Sonar/PMD warnings, and on my TODO
list I had put the task of migrating the Cactus tests to the current test
harness as well.

Fixing the Sonar/PMD warnings are small incremental changes, typically 1
fix of a specific type per commit. Migrating all the Cactus tests is
altogether a big change, but the commits itself would be small, likely one
test at a time per commit.

What would be the recommended way to continue now?

Kind regards,
Arjan Tijms

On Fri, Feb 17, 2017 at 10:16 PM, Edward Burns <>

> Executive Summary: Ed asks for dev list discussion of significant
> changes, such as moving API classes from jsf-api/src/main/java.
> Details:
> >>>>> On Tue, 31 Jan 2017 14:31:07 -0700, manfred riem <
>> said:
> MR> Hi all,
> MR> The MOJARRA_2_3X_ROLLING branch has been created and going forward all
> MR> the remaining JSF 2.3 work
> MR> and the JSF 2.3.x maintenance will be done in that branch.
> MR> The trunk is now open again and its target is
> Hello Mojarra Developers,
> I know there has not been much traffic on this list in the past couple
> years, but now that JSF 2.3 is nearly done, perhaps we may see more
> implementation-only traffic.
> To that end, I have to say I was taken by surprise when I went to
> backport the removal of the UIWebsocket "port" property from the 2.3
> branch to master, only to find that the API classes have been moved from
> their home in jsf-api/src/main/java, where they have been for at least
> the last seven years.
> Apparently this change was done in commit b230fe4.
> Now, as you all know, I'm all for transparency and empowerment, but I
> think such sigfinicant changes should at least be announced and maybe
> discussed before being made. For example, the build logic that
> generates the JSF API jar will now need to be changed before any further
> official generation of the javax.faces:javax.faces-api jar after 2.3.
> I'd like to re-establish a policy of discussion here on the dev list for
> such large changes. For example: any move to roll back away from the
> long standing process of using code generation to generate the tag
> handlers and such needs to be discussed before it is made.
> I don't want to put the brakes on progress too much, but I think
> transparency needs to go both ways.
> Thanks,
> Ed
> --
> | | office: +1 407 458 0017
> | 12 business days until planned start of JSF 2.3 Final Approval Ballot
> | 2 business days until DevNexus 2017
> | 27 business days until JavaLand 2017