Re: Still closed Re: Please hold external commits to master until at least Thursday

From: arjan tijms <>
Date: Fri, 25 Sep 2015 15:27:41 +0200


On Thu, Sep 24, 2015 at 9:26 PM, Edward Burns <> wrote:
>>>>>> On Tue, 22 Sep 2015 11:37:51 -0700, Edward Burns <> said:
> I'm sorry but I do not have good news on the ADF test front. I was
> hoping to integrate JAVASERVERFACES_SPEC_PUBLIC-1 to master today but
> the following ADF numbers cause me to have to pursue cleaning the
> numbers up first.

What are the ADF tests exactly testing? Is this something I can setup
and run locally, so I can test any change on those tests too before
committing anything?
A few questions here:

Are there 11~15 tests failing all the time? What are they failing on?

What happened on 20150911? That's the highest number in this snapshot
of runs, but it went back to 11 two days after

> I inspected the commits to 2.3 master in the range 2015-09-15 -
> 2015-09-22. In that range, commits came from the following individuals
> (with the type of commit):

In the table it seems that things diverged from 20150920, and the last
run before that is 20150918. The Mojarra timestamp is a little
behind; 20150917.

How are the commits from 2015-09-15 related to this?

> Zhijun: javadoc
> Arjan: work on CDI producers
> Manfred: nbproject, pom, javadoc for BCP-47
> Ed: remove lambda from CdiExtension.processBean(), javadoc
> We can rule out Zhijun and Manfred as the possible causes. We can rule
> out Ed as a cause because the lambda change only impacted deployment on
> JDK1.8u60 and the ADF tests run on an earlier JDK.

Although unlikely, theoretically the fact that a bug didn't manifest
on JDK8u60, doesn't necessarily have to mean that the workaround
doesn't have consequences for earlier JDKs. But as mentioned, this
seems unlikely as the Mojarra tests would likely have failed before

> Let me ask Manfred if we can modify the test job to pull a specific
> commit: cfea96318ea1b8de2615e7a450860fa7b017ae86. This was the last
> commit before the first of two commits from Arjan in that date range.

Okay, I'll await that. Depending on the outcome of that run, we could
see if removing some of the addBean calls in CDIExtension have any
effect, but it's perhaps too early to speculate about that. It would
help though to have an indication of what is exactly failing at the

Kind regards,
Arjan Tijms