Hi Zhijun,
Go ahead and commit it.
Thanks!
Kind regards,
Manfred Riem
On 8/24/15, 10:32 PM, zhijun Ren wrote:
> Hi Manfred and Ed,
>
> Arjan's comments fixed, please help to review the latest change, if no
> comments, I will commit it tomorrow.
>
> Cause there is javadoc compiling issue in 2.3, so I will commit the
> change in 2.2.x branch first.
>
> BR,
> Zhijun
>
> On 8/24/15, 23:55, manfred riem wrote:
>> Hi Zhijun,
>>
>> Arjan has added some comments to the issue.
>>
>> Can you please review those?
>>
>> Thanks!
>>
>> Kind regards,
>> Manfred Riem
>>
>> On 8/24/15, 2:40 AM, zhijun Ren wrote:
>>> Hi Ed and Manfred,
>>>
>>> https://java.net/jira/browse/JAVASERVERFACES-4021
>>>
>>> Please help to review the code for the issue4021, change bundle
>>> attached in the JIRA bug.
>>>
>>> My change is based on the 2.2.x cause I met javadoc compiling issue
>>> in 2.3(trunk).
>>>
>>> Tests added and passed and no regression found in 2.2.x branch.
>>>
>>> BR,
>>> Zhijun
>>>
>