dev@javaserverfaces.java.net

Re: Code review request for https://java.net/jira/browse/JAVASERVERFACES-3582

From: manfred riem <manfred.riem_at_oracle.com>
Date: Mon, 09 Feb 2015 08:44:58 -0600

Hi Zhijun,

Unfortunately you cannot commit this as you are changing an API signature.

As we discussed before for this issue you need to look to see if the
test can be made to pass without changing the API signature.

If that is not possible then we need to make sure the test itself is
adjusted.

Please verify the behavior against an older 2.1 release.

Kind regards,
Manfred


On 2/9/15, 2:12 AM, zhijun Ren wrote:
> Hi Manfred and Ed,
>
> Please help to review the code attached on 20150209, please note that
> I have all the Hudson test cases locally against WLS and didn't found
> any failed test cases.
>
> attached the change here for your convenience.
>
> BR,
> Zhijun
>
>