Hi Ed and Manfred,
Comments fixed and new change bundle attached, please review again.
Thanks,
Zhijun
On 11/25/14, 6:51, Ed Burns (JIRA) wrote:
> [ https://java.net/jira/browse/JAVASERVERFACES-3538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=381970#comment-381970 ]
>
> Ed Burns commented on JAVASERVERFACES-3538:
> -------------------------------------------
>
> M jsf-ri/src/main/java/com/sun/faces/renderkit/html_basic/ScriptStyleBaseRenderer.java
> M test/agnostic/facelets/cc/src/main/java/com/sun/faces/test/agnostic/facelets/composite/TestBean.java
> M test/agnostic/facelets/cc/src/main/webapp/WEB-INF/web.xml
>
>
> A + test/agnostic/facelets/cc/src/main/webapp/WEB-INF/asw-taglib.xml
> A + test/agnostic/facelets/cc/src/main/webapp/ccAttrsValue.xhtml
> A + test/agnostic/facelets/cc/src/main/webapp/ccAttrsValuePrependIdTrue.xhtml
> A + test/agnostic/facelets/cc/src/main/webapp/ccClientId.xhtml
> A + test/agnostic/facelets/cc/src/main/webapp/resources/ccAttrsValue
> A + test/agnostic/facelets/cc/src/test/java/com/sun/faces/test/agnostic/facelets/composite/Issue19667737IT.java
>
> First, please make sure to not commit files that are flagged with a "+".
> To remove the "+", svn revert the file than svn add it.
>
> Second, make sure to add all the children of the ccAttrsValue directory.
>
> Finally, the core changes look fine.
>
> Thanks,
>
> Ed
>
> r=edburns
>
>> [PORT to 2.2.8] Port JAVASERVERFACES-3485 to branches/2.2.8
>> -----------------------------------------------------------
>>
>> Key: JAVASERVERFACES-3538
>> URL: https://java.net/jira/browse/JAVASERVERFACES-3538
>> Project: javaserverfaces
>> Issue Type: Bug
>> Components: renderkit
>> Affects Versions: 2.2.8-03
>> Reporter: Ed Burns
>> Assignee: ren.zhijun.oracle
>> Attachments: changebundle.20141124.zhijun.txt, newfiles.zip
>>
>>
>> Port JAVASERVERFACES-3485 to branches/2.2.8
>
>
> --
> This message was sent by Atlassian JIRA
> (v6.2.3#6260)