Hi Manfred,
Your comments fixed, change bundle attached(including
ServerSideStateHelper), please review.
BR,
Zhijun
On 8/27/14, 9:13, zhijun Ren wrote:
> Hi Manfred,
>
> For the code change for ServerSideStateHelper, I have given up my
> first time change, you can refer to the attached change bundle in the
> previous mail.
>
> BR,
> Zhijun
>
> On 8/26/14, 23:30, manfred riem wrote:
>> Hi Zhijun,
>>
>> Can you please move the testcase to
>> test/servlet30/stateSaving/viewExpiredException ?
>>
>> The test/agnostic directory is not to be used to add new tests.
>>
>> Also did you change the ServerSideStateHelper to have one return? Did
>> I miss it?
>>
>> Thanks for the great work!
>>
>> Regards,
>> Manfred
>>
>> On 8/25/14, 1:02 AM, zhijun Ren wrote:
>>> Hi Manfred,
>>>
>>> https://java.net/jira/browse/JAVASERVERFACES-3359
>>>
>>> Test case added for this bug, please help to review the updated code
>>> whose changed bundle attached here.
>>>
>>> Thanks,
>>> Zhijun
>>>
>>> On 8/19/14, 21:29, manfred riem wrote:
>>>> Hi Zhijun,
>>>>
>>>> Can ypu please make sure there is only one exit point (one return)?
>>>>
>>>> Also you will need to include a test in the changebundle as well.
>>>>
>>>> Thanks!
>>>> Manfred
>>>>
>>>> On 8/19/14, 1:03 AM, zhijun Ren wrote:
>>>>> Hi Manfred and Ed,
>>>>>
>>>>> https://java.net/jira/browse/JAVASERVERFACES-3359
>>>>> |Please refer the JIRA comments which I added for code diff and the test results.
>>>>>
>>>>> BR,
>>>>> Zhijun
>>>>> |
>>>>>