Hi Manfred and Ed,
All comments have been fixed and code committed, thanks.
BR,
Zhijun
On 7/22/14, 22:20, manfred riem wrote:
> Hi Zhijun,
>
> See the issue itself for what needs to be done.
>
> Thanks for your effort!
> Manfred
>
> On 7/22/14, 7:32 AM, zhijun Ren wrote:
>> Hi Ed and Manfred,
>>
>> Code is ready for http://java.net/jira/browse/JAVASERVERFACES-3246
>> now, please help to do review.
>>
>> attached the changebundle.txt and the newly added files here for your
>> reference.
>>
>> Notes:
>>
>> 1. Ed's solution failed one TC. [ testCalculateLocaleLang() in
>> TestViewHandlerImpl ]
>> As ADF team buy-in Ed's approach, so I changed the test case:
>>
>> From:
>> assertTrue(locale.equals(Locale.ENGLISH));
>>
>> To:
>> assertTrue(locale.getLanguage().equals(Locale.ENGLISH.getLanguage()));
>>
>> 2. Regression TC added as Ed required, all mvn TCs under ./test were
>> passed. (steps are the same as those in Hudson)
>>
>> 3. I run the 'ant clean.mojarra.only main
>> test.with.container.refresh' locally, all TCs passed beside
>> JAVASERVERFACES-2113 in MOJARRA_2_1X_ROLLING/jsf-test/build.xml,
>> which always failed in my machine and is not related to code change.
>> (I commented it out when I do the test).
>>
>>
>> BR,
>> Zhijun