dev@javaserverfaces.java.net
Re: Seeking Review: JAVASERVERFACES-2066
This message
: [
Message body
] [ More options (
top
,
bottom
) ]
Related messages
: [
Next message
] [
Previous message
] [
In reply to
]
Contemporary messages sorted
: [
by date
] [
by thread
] [
by subject
] [
by author
] [
by messages with attachments
]
From
: Jason Lee <
jason_at_steeplesoft.com
>
Date
: Fri, 20 May 2011 14:31:08 -0500
On 5/20/11 2:19 PM, Roger Kitain wrote:
>
http://java.net/jira/browse/JAVASERVERFACES-2066
>
Looks mostly OK, though I think your assignment could simply be:
isRowHeader = Boolean.valueOf(rowHeaderValue.toString());
Also not a big fan of assignments inside conditionals like that, fwiw.
Makes the code a bit harder to read. Other than that, it looks fine to me.
-- Jason Lee
http://blogs.steeplesoft.com
http://twitter.com/jasondlee
This message
: [
Message body
]
Next message
:
Roger Kitain: "Seeking Review: JAVASERVERFACES-2067"
Previous message
:
Roger Kitain: "Seeking Review: JAVASERVERFACES-2066"
In reply to
:
Roger Kitain: "Seeking Review: JAVASERVERFACES-2066"
Contemporary messages sorted
: [
by date
] [
by thread
] [
by subject
] [
by author
] [
by messages with attachments
]