dev@javaserverfaces.java.net

Re: fix for issue 924 (merging the JSF api and impl jar into a single jar)

From: Andy Schwartz <andy.g.schwartz_at_gmail.com>
Date: Fri, 12 Nov 2010 11:24:00 -0500

Hi Sheetal -

On Fri, Nov 5, 2010 at 2:04 PM, Sheetal Vartak
<sheetal.vartak_at_oracle.com> wrote:
>
> Just wanted to give an heads up that I am planning on fixing issue 924 that talks about merging the
> jsf-api.jar and jsf-impl.jar into a single jar. Once this fix is checked in, for updating the JSF bits in an
> environment, one would need to delete both jsf-api.jar and jsf-impl.jar and then copy the new single jar file

Just wanted to verify that the jsf-api.jar and jsf-impl.jar will
continue to exist as always - ie. the new merged jar will be provided
as a convenience, not as a requirement. This isn't clear from the
issue tracker.

> This fix is a partial fix for issue 1826 as well.

I am concerned about coupling these two issues. 1826 seems like a
functional issue that needs to be resolved independently of jar
packaging.

Also, I find the following statement from the issue tracker troubling:

> If we did this, then code in jsf-api could access com.sun.faces classes directly.

API classes should not reference implementation (com.sun.faces)
classes directly. One of the main reasons for the very common
practice of splitting API and implementation into separate jars is to
avoid exactly this sort of reverse dependency.

Andy