dev@javaserverfaces.java.net

Re: Servlet dependency in Mojarra RenderResponsePhase.execute() method

From: Andy Schwartz <andy.g.schwartz_at_gmail.com>
Date: Tue, 19 Jan 2010 18:58:29 -0500

Hey Ed -

On Tue, Jan 19, 2010 at 5:47 PM, Ed Burns <Ed.Burns_at_sun.com> wrote:

> Can someone please tell me if we actually need OnOffResponseWrapper?  It
> doesn't even seem to be installed anywhere.

Funny thing... I was looking at this code yesterday and came to the
same conclusion. As far as I can tell this class is not performing
any function at the moment and can be removed.

However, the class doc says:

* <p>An HttpServletResponseWrapper that can be enabled or disabled
* with respect to the methods that deal with the writing of contents
* to the response. This is necessary to avoid sending content
* that appears outside of the <f:view> tag to the Ajax response.

I can understand how in JSP-land content outside of <f:view> might end
up being written directly back to the browser by the JSP engine (and
we work around this in Trinidad/ADF Faces), though I am not sure how
this would be an issue for Facelets.

Perhaps Roger remembers what use case prompted the addition of this code?

Andy