Re: Checking in Andy's 180-TreeVisitor API

From: Ed Burns <Ed.Burns_at_Sun.COM>
Date: Wed, 10 Dec 2008 06:02:06 -0800

Andy, are you on dev? If so, I'll not manually add you to the To: list.

More difficult questions below.

>>>>> On Wed, 10 Dec 2008 07:13:43 -0500, Andy Schwartz <> said:

AS> Sweet, thanks for getting this in Ed!
AS> Just in case anyone is curious, remaining work includes:

AS> 1. Move PartialVisitContext/FullVisitContext out of the API.

Andy, this was part of my initial checkin, so you're off the hook there.
Please check it of course.

AS> 2. Adjust VisitContext contract as necessary to account for the fact
AS> that we'll no longer have a PartialVisitContext API (may need to promote
AS> some PartialVisitContext methods up to VisitContext).

Andy there ware no such methods in your zip. The signatures of
VisitContext and its subclasses were identical in your zip. Please
check this.

AS> 3. Call UIComponent.pushComponentToEL() and popComponentToEL() during
AS> the visit traversal.

VERY important. Not done yet. Can we put this on your plate? Make
sure to include a requirement to do this in the javadocs as well.

AS> 4. VisitHint cleanup: Defaults should match invokeOnComponent behavior.
AS> Hint names should be updated accordingly. Rip out VISIT_ITERATED. Add
AS> a hint that indicates that the visit is due to lifecycle phase execution.

Not done yet. Andy can you do it?

AS> 5. Rip out old doTreeTraversal() code.

This is done, but please check it.

AS> 6. Implement UIData.visitTree()

Yes, very important. Can you do it?

I assume for all the tasks above that I ask, "Can you do it?" you'll
reply letting me know the answer.


|  | office: 408 884 9519 OR x31640
| homepage:         |