Ed Burns wrote:
>>>>>> On Wed, 03 Dec 2008 08:57:03 +0000, Pete Muir said:
>>>>>>
>
> PM> Yes, that seems like a good approach.
> PM> On 2 Dec 2008, at 19:25, Ed Burns wrote:
>
> Seeking review for
> https://javaserverfaces-spec-public.dev.java.net/issues/show_bug.cgi?id=451
>
> Attachment at
> https://javaserverfaces-spec-public.dev.java.net/nonav/issues/showattachment.cgi/171/changebundle.txt
>
> Inline below:
>
> Issue: 451 part 1 of 2
>
> This part deals with the introduction of the "noSelectionOption"
> property on UISelectItem, SelectItem, and f:selectItem, in both Facelets
> and JSP. When a select item is encountered that has "true" for the
> value of this property, *and* the select* that contains the select item
> has required="true", then the select* should fail validation.
>
> FWIW, I had to modify code to implement this feature, and the code was
> very well factored and easy to modify.
>
>
> SECTION: Modified Files
> ----------------------------
> M jsf-api/src/javax/faces/model/SelectItem.java
>
> - Modify 5 arg ctor to be 6 arg ctor where the last arg is the boolean
> value of the noSelectionOption property.
>
>
>
Agree with qoob on the constructor change. It's a backwards
incompatible change.