dev@javaserverfaces.java.net

Re: recent changes to ApplicationImpl or WebConfiguration ?

From: Ryan Lubke <Ryan.Lubke_at_Sun.COM>
Date: Thu, 04 Dec 2008 10:50:06 -0800

Matthias Wessendorf wrote:
> any chance to get the fix in soon ? :-)
>
We're spread a little thin at the moment working on 2.0.
It's on my list of things to get to. That said, if you want to
sign the SCA and provide an official change bundle, that would
certainly help us get it fixed sooner.
> Thanks!
> (and sorry for pushing)
>
> On Tue, Dec 2, 2008 at 8:50 AM, Matthias Wessendorf <matzew_at_apache.org> wrote:
>
>> On Tue, Dec 2, 2008 at 12:04 AM, Ryan Lubke <Ryan.Lubke_at_sun.com> wrote:
>>
>>> Ryan Lubke wrote:
>>>
>>>> Matthias Wessendorf wrote:
>>>>
>>>>> Hi,
>>>>>
>>>>> in Trinidad we have a "Configurator" framework (invoked by a filter).
>>>>> That does a setup for the ExternalContext.
>>>>>
>>>>> In that we do things like this:
>>>>>
>>>>> public static void init(Application app, ExternalContext extContext)
>>>>> {
>>>>> GenericConverter conv = new DomainConverter();
>>>>>
>>>>> GenericConverterFactory.getCurrentInstance(extContext).registerConverter(conv);
>>>>>
>>>>> app.addConverter(oracle.jbo.domain.Number.class,
>>>>>
>>>>> "org.apache.myfaces.trinidadinternal.convert.NumberConverter");
>>>>> .....
>>>>> }
>>>>>
>>>>> Now I am seeing this:
>>>>>
>>>>>
>>>>> com.sun.faces.config.WebConfiguration.getInstance(WebConfiguration.java:123)
>>>>> at
>>>>>
>>>>> com.sun.faces.application.ApplicationImpl.addPropertyEditorIfNecessary(ApplicationImpl.java:705)
>>>>> at
>>>>>
>>>>> com.sun.faces.application.ApplicationImpl.addConverter(ApplicationImpl.java:673)
>>>>> at
>>>>> blah.mw.SomeClass.init(SomeClass.java:37)
>>>>>
>>>>>
>>>>> Was there a "FacesContext.getCurrentInstance()" introduced in the
>>>>> WebConfiguration ?
>>>>>
>>>>>
>>>> FacesContext.getCurrentInstance() is called from there, but that's not a
>>>> recent change. Last time WebConfiguration.getInstance() was modified was
>>>> 7/26/07.
>>>>
>>> Actually, ApplicationImpl does now call WebConfiguration to see if a
>>> particular feature
>>> is enabled or disabled (the one related to converter/PropertyEditory
>>> support).
>>>
>>> If it's an issue, please log a bug.
>>>
>> Thanks, I did that:
>> https://javaserverfaces.dev.java.net/issues/show_bug.cgi?id=870
>>
>> -M
>>
>>
>>>>> Thanks,
>>>>> Matthias
>>>>>
>>>>>
>>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe_at_javaserverfaces.dev.java.net
>>>> For additional commands, e-mail: dev-help_at_javaserverfaces.dev.java.net
>>>>
>>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe_at_javaserverfaces.dev.java.net
>>> For additional commands, e-mail: dev-help_at_javaserverfaces.dev.java.net
>>>
>>>
>>>
>>
>> --
>> Matthias Wessendorf
>>
>> blog: http://matthiaswessendorf.wordpress.com/
>> sessions: http://www.slideshare.net/mwessendorf
>> twitter: http://twitter.com/mwessendorf
>>
>>
>
>
>
>