dev@javaserverfaces.java.net

[UIViewRoot] repeating code

From: Matthias Wessendorf <matzew_at_apache.org>
Date: Wed, 26 Mar 2008 17:08:34 +0100

Hi,

in these four methods:
-processDecodes()
-processValidatiors()
-processUpdates()
-processApplication()


we see always these lines of code:
...
      if (context.getRenderResponse() || context.getResponseComplete()) {
          if (events != null) {
              for (List<FacesEvent> eventList : events) {
                  if (eventList != null) {
                      eventList.clear();
                  }
              }
              events = null;
          }
      }
...

Would you mind to refactor that to some thing like "private void
clearFacesEvents(FacesContext context);" ?

If you "agree" on the name, I could come up with a patch. I think this
can be targeted for JSF 1.2 AND 2.0

Thanks,
Matthias

-- 
Matthias Wessendorf
further stuff:
blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
mail: matzew-at-apache-dot-org