Re: [REVIEW] Minor improvements to UIData

From: Ed Burns <>
Date: Tue, 28 Aug 2007 09:59:25 -0700

>>>>> On Tue, 28 Aug 2007 09:36:44 -0700, Ryan Lubke <Ryan.Lubke_at_Sun.COM> said:

EB> I'm really sorry, but with a change like this, I have to ask why there
EB> is no addition to the automated tests? Unless there is some good reason
EB> for there not to be one, I cannot give an r=edburns.

RL> And what exactly would you propose? There is a comprehensive set of
RL> tests that already
RL> exist for data tables/nested datatables. This didn't change how
RL> datatable ultimately behaves,
RL> all this tries to do is reduce the number of temp objects created.

I'll trust your judgement if you say the code change would be exercised
by existing tests. That's fine for me.

r=edburns in that case.

|  | office: 408 884 9519 OR x31640
| homepage:         |
| aim: edburns0sunw | iim: