OK. If you're comfortable with it, I am. You already have Roger's, so
for what little this is worth:
r=jdlee
-----
Jason Lee, SCJP
Senior Software Engineer
http://www.iec-okc.com
> -----Original Message-----
> From: Ryan.Lubke_at_Sun.COM [mailto:Ryan.Lubke_at_Sun.COM]
> Sent: Tuesday, May 15, 2007 11:06 PM
> To: dev_at_javaserverfaces.dev.java.net
> Subject: Re: [REVIEW] Fine tuning of parsing/validation code for _05
>
> Jason Lee wrote:
> > The only thing that jumps out at me are possible dangling
> InputStreams:
> >
> > DOMSource domSource
> > = new DOMSource(db.parse(getInputStream(documentURL),
> > documentURL.toExternalForm()));
> >
> > URL url = DbfFactory.class.getResource(FACES_1_2_XSD);
> > URLConnection conn = url.openConnection();
> conn.setUseCaches(false);
> > InputStream in = conn.getInputStream();
> >
> >
> > [Not sure about this one]
> > if (source != null) {
> > return new Input(source.getByteStream()); }
> >
> > Am I off-base?
> >
> IIRC, SAX used under the covers by DOM, closes the streams
> automatically.
>
> Could be wrong though.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_javaserverfaces.dev.java.net
> For additional commands, e-mail: dev-help_at_javaserverfaces.dev.java.net
>
>