dev@javaserverfaces.java.net

[REVIEW] Add a timing logger definition

From: Ryan Lubke <Ryan.Lubke_at_Sun.COM>
Date: Wed, 07 Feb 2007 12:53:52 -0800


Add a new logger definition 'timing'
to break the execution time log statements away
from general application logging.


SECTION: Modified Files
----------------------------
M src/com/sun/faces/lifecycle/LifecycleImpl.java
M src/com/sun/faces/util/Util.java


SECTION: Diffs
----------------------------
Index: src/com/sun/faces/lifecycle/LifecycleImpl.java
===================================================================
RCS file: /cvs/javaserverfaces-sources/jsf-ri/src/com/sun/faces/lifecycle/LifecycleImpl.java,v
retrieving revision 1.71
diff -u -r1.71 LifecycleImpl.java
--- src/com/sun/faces/lifecycle/LifecycleImpl.java 6 Dec 2006 19:52:51 -0000 1.71
+++ src/com/sun/faces/lifecycle/LifecycleImpl.java 7 Feb 2007 20:47:47 -0000
@@ -62,6 +62,8 @@
     // Log instance for this class
     private static Logger LOGGER = Util.getLogger(Util.FACES_LOGGER
             + Util.LIFECYCLE_LOGGER);
+ private static Logger TIMING_LOGGER = Util.getLogger(Util.FACES_LOGGER
+ + Util.TIMING_LOGGER);
 
 
     // ------------------------------------------------------ Instance Variables
@@ -248,8 +250,8 @@
                 long start = System.currentTimeMillis();
                 phase.execute(context);
                 long stop = System.currentTimeMillis();
- if (LOGGER.isLoggable(Level.FINE)) {
- LOGGER.fine("TIMING: Exectution time for phase '"
+ if (TIMING_LOGGER.isLoggable(Level.FINE)) {
+ TIMING_LOGGER.fine("TIMING: Exectution time for phase '"
                         + phaseId.toString()
                         + "': "
                         + (stop - start));
Index: src/com/sun/faces/util/Util.java
===================================================================
RCS file: /cvs/javaserverfaces-sources/jsf-ri/src/com/sun/faces/util/Util.java,v
retrieving revision 1.206
diff -u -r1.206 Util.java
--- src/com/sun/faces/util/Util.java 31 Jan 2007 22:44:19 -0000 1.206
+++ src/com/sun/faces/util/Util.java 7 Feb 2007 20:44:55 -0000
@@ -103,7 +103,8 @@
     public static final String APPLICATION_LOGGER = ".application";
     public static final String CONTEXT_LOGGER = ".context";
     public static final String CONFIG_LOGGER = ".config";
- public static final String LIFECYCLE_LOGGER = ".lifecycle";
+ public static final String LIFECYCLE_LOGGER = ".lifecycle";
+ public static final String TIMING_LOGGER = ".timing";
 
     /**
      * Flag that, when true, enables special behavior in the RI to enable