RE: [REVIEW - PART 2] Avoid full lifecycle processing for images when using prefix mapping
r=jdlee
-----
Jason Lee, SCJP
Programmer/Analyst
http://www.iec-okc.com
> -----Original Message-----
> From: Ryan.Lubke_at_Sun.COM [mailto:Ryan.Lubke_at_Sun.COM]
> Sent: Monday, October 16, 2006 3:27 PM
> To: dev_at_javaserverfaces.dev.java.net
> Subject: [REVIEW - PART 2] Avoid full lifecycle processing
> for images when using prefix mapping
>
> I've attached a follow up change bundle to this issue.
> It turns out that the PhaseListener approach isn't going to
> work (causes issues with Shale). I've instead moved the PL
> logic into ViewHandlerImpl.renderView().
>
>
>
> Ryan Lubke wrote:
> > Avoid full lifecycle processing with the FacesServlet is
> prefix mapped
> > and images are defined using relative URIs.
> >
> >
> > SECTION: Modified Files
> > ----------------------------
> > M src/com/sun/faces/jsf-ri-config.xml
> >
> > A src/com/sun/faces/lifecycle/ImagePhaseListener.jav
> >
> >
> > SECTION: Diffs
> > ----------------------------
> > Index: src/com/sun/faces/jsf-ri-config.xml
> > ===================================================================
> > RCS file:
> >
> /cvs/javaserverfaces-sources/jsf-ri/src/com/sun/faces/jsf-ri-config.xm
> > l,v
> > retrieving revision 1.69
> > diff -u -r1.69 jsf-ri-config.xml
> > --- src/com/sun/faces/jsf-ri-config.xml 11 May 2006 18:48:03
> > -0000 1.69
> > +++ src/com/sun/faces/jsf-ri-config.xml 11 Oct 2006
> 00:55:38 -0000
> > @@ -167,9 +167,10 @@
> >
> <converter-class>javax.faces.convert.EnumConverter</converter-class>
> > </converter>
> > - <!-- Add our InitializingPhaseListener -->
> > + <!-- Add our implementation specific PhaseListeners -->
> > <lifecycle>
> >
> >
> <phase-listener>com.sun.faces.lifecycle.ELResolverInitPhaseListener</p
> > hase-listener>
> >
> > +
> >
> <phase-listener>com.sun.faces.lifecycle.ImagePhaseListener</phase-list
> > ener>
> >
> > </lifecycle>
> >
> > <!-- Configure Standard Validators -->
> >
> >
> > SECTION: New Files
> > ----------------------------
> > SEE ATTACHMENTS
> >
> ----------------------------------------------------------------------
> > --
> >
> >
> ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe_at_javaserverfaces.dev.java.net
> > For additional commands, e-mail:
> dev-help_at_javaserverfaces.dev.java.net
> >
>
>