RE: [REVIEW] Re: Revist jsf-tools/template-src/TypedCollections.java
r=jdlee
-----
Jason Lee, SCJP
Programmer/Analyst
http://www.iec-okc.com
> -----Original Message-----
> From: Ryan.Lubke_at_Sun.COM [mailto:Ryan.Lubke_at_Sun.COM]
> Sent: Thursday, October 12, 2006 3:51 PM
> To: dev_at_javaserverfaces.dev.java.net
> Subject: [REVIEW] Re: Revist
> jsf-tools/template-src/TypedCollections.java
>
> Ryan Lubke wrote:
> > Hey All,
> >
> > I wasn't thinking about performance when reviewing the
> change bundle
> > that included the addition of
> > jsf-tools/template-src/TypedCollections.java.
> >
> > This was added primarily to get around various cast
> compiler warnings
> > that became prevalent when we moved to 1.5.
> > My concern is that TypedCollections does an iteration through the
> > collection to ensure the types of said collection match the input
> > arguments. If not then throw a ClassCastException. This can
> > potentially result in two iterations over the same collection.
> >
> > Before this was in place, we would just let the ClassCastException
> > happen during iteration, so I suggest we go back to doing that and
> > remove the type validation logic from TypedCollections.
> >
> > Thoughts?
> >
> >
> ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe_at_javaserverfaces.dev.java.net
> > For additional commands, e-mail:
> dev-help_at_javaserverfaces.dev.java.net
> >
>
>