Roger,
I only added the NPE because it would be more consistent w/ UIComponentTag.setBinding(), which calls isValueReference() on the String argument. isValueReference() would then throw a NPE if the arg was null. I don't feel passionate about it though ;)
Do most of these discussions take place in the issue tracker for this project? I don't want to be loud.
Dennis Byrne
>-----Original Message-----
>From: Roger Kitain [mailto:Roger.Kitain_at_Sun.COM]
>Sent: Monday, June 19, 2006 02:46 PM
>To: dev_at_javaserverfaces.dev.java.net
>Subject: Re: Change UIComponentELTag.setBinding() ?
>
>Hello Dennis -
>
>Thanks for catching this. This looks lke a carry over from UIComponentTag.
>I've create an issue for this in our issue tracker. I'm thinking we can
>throw a
>JspException if the arg is not a valid ValueExpression, but I'm not
>convinced that
>the NPE check is necessary, since the hasBinding method is available for
>use.
>
>-roger
>
>Dennis Byrne wrote:
>
>>The javadocs say UIComponentELTag.setBinding() throws an IllegalArgumentException, but it is just a plain setter and the signature throws JspException.
>>
>>http://fisheye5.cenqua.com/browse/~raw,r=1.4/javaserverfaces-sources/jsf-api/src/javax/faces/webapp/UIComponentELTag.java
>>
>>Can we please change this to explicitly throw a JspException if the parameter is not a value reference, and a NPE if the parameter is null?
>>
>>Dennis Byrne
>>
>>
>>---------------------------------------------------------------------
>>To unsubscribe, e-mail: dev-unsubscribe_at_javaserverfaces.dev.java.net
>>For additional commands, e-mail: dev-help_at_javaserverfaces.dev.java.net
>>
>>
>>
>
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: dev-unsubscribe_at_javaserverfaces.dev.java.net
>For additional commands, e-mail: dev-help_at_javaserverfaces.dev.java.net
>
>