dev@javaserverfaces.java.net

Re: [REVIEW] Log informational error message if an action listener throws an exception when being invoked

From: Adam Winer <adam.winer_at_oracle.com>
Date: Wed, 22 Feb 2006 15:11:34 -0800

Shouldn't RuntimeExceptions thrown by a MethodExpression
simply be re-thrown?

-- Adam


Ed Burns wrote:
>>>>>> On Wed, 22 Feb 2006 09:32:47 -0800, Ryan Lubke <Ryan.Lubke_at_Sun.COM> said:
>
> RL> This change bundle addresses one issue[1] pointed out by Cay Horstmann, and
> RL> opens a whole new can of worms (that can being the localization of the API).
>
> RL> [1] http://www.horstmann.com/elvis/hated-error-messages.html
>
> RL> SECTION: Modified Files
> RL> ----------------------------
> RL> M build.xml
> RL> - include the LogStrings.properties in jsf-api.jar
>
> RL> M src/javax/faces/event/MethodExpressionActionListener.java
> RL> - log an informational error message when the MethodExpression
> RL> throws an Exception. The AbortProcessing exception is caught
> RL> by UIViewRoot, but it ignores it to allow the processing of other
> RL> events.
>
>
> RL> A src/javax/faces/LogStrings.properties
> RL> - thus begins the long journey of localizing the API
>
> Very nice.
>
> r=edburns
>