From: Ryan Lubke <Ryan.Lubke_at_Sun.COM>
Date: Wed, 25 Jan 2006 08:55:59 -0800

PENDING cleanup.


SECTION: Modified Files
----------------------------
M src/com/sun/faces/renderkit/html_basic/HtmlResponseWriter.java


SECTION: Diffs
----------------------------
Index: src/com/sun/faces/renderkit/html_basic/HtmlResponseWriter.java
===================================================================
RCS file: /cvs/javaserverfaces-sources/jsf-ri/src/com/sun/faces/renderkit/html_basic/HtmlResponseWriter.java,v
retrieving revision 1.22
diff -u -r1.22 HtmlResponseWriter.java
--- src/com/sun/faces/renderkit/html_basic/HtmlResponseWriter.java 11 Jan 2006 15:28:09 -0000 1.22
+++ src/com/sun/faces/renderkit/html_basic/HtmlResponseWriter.java 25 Jan 2006 16:54:42 -0000
@@ -188,11 +188,8 @@
                 dontEscape = true;
             }
         }
-
-
- //PENDING (horwat) using String as a result of Tomcat char writer
- // ArrayIndexOutOfBoundsException (3584)
- writer.write("<");
+
+ writer.write('<');
         writer.write(name);
         closeStart = true;
     }
@@ -226,15 +223,13 @@
                 return;
             }
 
- writer.write(">");
+ writer.write('>');
             closeStart = false;
         }
 
         writer.write("</");
- writer.write(name);
- //PENDING (horwat) using String as a result of Tomcat char writer
- // ArrayIndexOutOfBoundsException (3584)
- writer.write(">");
+ writer.write(name);
+ writer.write('>');
     }
 
 
@@ -318,10 +313,8 @@
             throw new NullPointerException(MessageUtils.getExceptionMessageString(
                 MessageUtils.NULL_PARAMETERS_ERROR_MESSAGE_ID));
         }
-
- //PENDING (horwat) using String as a result of Tomcat char writer
- // ArrayIndexOutOfBoundsException (3584)
- writer.write(" ");
+
+ writer.write(' ');
         writer.write(name);
         writer.write("=\"");
 
@@ -333,10 +326,8 @@
         } else {
             HtmlUtils.writeURL(writer, stringValue, encoding);
         }
-
- //PENDING (horwat) using String as a result of Tomcat char writer
- // ArrayIndexOutOfBoundsException (3584)
- writer.write("\"");
+
+ writer.write('"');
     }
 
 
@@ -503,10 +494,8 @@
      * already closed).
      */
     private void closeStartIfNecessary() throws IOException {
- if (closeStart) {
- //PENDING (horwat) using String as a result of Tomcat char
- // writer ArrayIndexOutOfBoundsException (3584)
- writer.write(">");
+ if (closeStart) {
+ writer.write('>');
             closeStart = false;
         }
     }