Re: [REVIEW] Ensure ViewExpiredException isn't wrapped when detected

From: Ed Burns <>
Date: Wed, 9 Nov 2005 06:02:29 -0800

>>>>> On Tue, 08 Nov 2005 13:01:08 -0800, Ryan Lubke <Ryan.Lubke_at_Sun.COM> said:

RL> With the current RI implementation, a developer currently can't
RL> add the following to their web.xml:

RL> <error-page>
RL> <exception-type>javax.faces.application.ViewExpiredException</exception-type>
RL> <location>/error.jsp</location>
RL> </error-page>

RL> and expect the error page to be triggered since the Lifecycle implementation
RL> wraps all caught exceptions as a FacesException.

RL> Modify the lifecycle to rethrow ViewExpiredExceptions when found.

RL> Tested with a simple app locally to confirm that the error page is now
RL> triggered.

RL> SECTION: Modified Files
RL> ----------------------------
RL> M src/com/sun/faces/lifecycle/
RL> - if 'ex' is a ViewExpiredException, rethrow
RL> - for the other case, unwind the exception chain
RL> and throw a new FacesException with the root
RL> cause of the chain

Can you please add a systest for this? Otherwise, I leave it to you to
integrate the best of the comments from Adam and Jacob.


|  | {home: 407 869 9587, office: 408 884 9519 OR x31640}
| homepage:         |
| aim: edburns0sunw | iim: