Re: Seeking Review: rename method to avoid conflict.
r=rlubke
Ed Burns wrote:
>Rename UIComponentTagBase.getIndex(), which was
>private in JSF 1.1, to
>getIndexOfNextChildTag() to avoid conflict with the
>MyFaces Tomahawk
>component library.
>
>SECTION: API Changes
>
>M
>jsf-api/src/javax/faces/webapp/UIComponentClassicTagBase.java
>M
>jsf-api/src/javax/faces/webapp/UIComponentTagBase.java
>
>- refactor from netbeans.
>
>SECTION: API Diffs
>
>Index:
>jsf-api/src/javax/faces/webapp/UIComponentClassicTagBase.java
>===================================================================
>RCS file:
>/cvs/javaserverfaces-sources/jsf-api/src/javax/faces/webapp/UIComponentClassicTagBase.java,v
>retrieving revision 1.10
>diff -u -r1.10 UIComponentClassicTagBase.java
>---
>jsf-api/src/javax/faces/webapp/UIComponentClassicTagBase.java
>5 Oct 2005 18:10:09 -0000 1.10
>+++
>jsf-api/src/javax/faces/webapp/UIComponentClassicTagBase.java
>4 Nov 2005 15:25:14 -0000
>@@ -450,7 +450,7 @@
>
> UIComponent component =
>createComponent(context, componentId);
> UIComponentTagBase parentTag =
>getParentUIComponentClassicTagBase(pageContext);
>-
>parent.getChildren().add(parentTag.getIndex(),
>component);
>+
>parent.getChildren().add(parentTag.getIndexOfNextChildTag(),
>component);
> created = true;
> return (component);
>
>@@ -661,7 +661,7 @@
> // Methods related to the createdComponents and
>createdFacets lists.
> //
>
>- protected int getIndex() {
>+ protected int getIndexOfNextChildTag() {
>
> if (createdComponents != null) {
> return (createdComponents.size());
>Index:
>jsf-api/src/javax/faces/webapp/UIComponentTagBase.java
>===================================================================
>RCS file:
>/cvs/javaserverfaces-sources/jsf-api/src/javax/faces/webapp/UIComponentTagBase.java,v
>retrieving revision 1.4
>diff -u -r1.4 UIComponentTagBase.java
>---
>jsf-api/src/javax/faces/webapp/UIComponentTagBase.java
>22 Aug 2005 22:08:11 -0000 1.4
>+++
>jsf-api/src/javax/faces/webapp/UIComponentTagBase.java
>4 Nov 2005 15:25:14 -0000
>@@ -146,6 +146,6 @@
> * components and returns the size of the
>list.</p>
> */
>
>- protected abstract int getIndex();
>+ protected abstract int getIndexOfNextChildTag();
>
> }
>
>
>
>
>
>__________________________________
>Yahoo! Mail - PC Magazine Editors' Choice 2005
>http://mail.yahoo.com
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: dev-unsubscribe_at_javaserverfaces.dev.java.net
>For additional commands, e-mail: dev-help_at_javaserverfaces.dev.java.net
>
>
>