Re: [Review] Fix for RI issue 134, 162 and legacy resolver bug

From: Ed Burns <>
Date: Tue, 9 Aug 2005 09:07:42 -0700

>>>>> On Mon, 08 Aug 2005 18:40:39 -0700, Jayashri Visvanathan <Jayashri.Visvanathan_at_Sun.COM> said:

JV> M src/com/sun/faces/application/
JV> M src/com/sun/faces/application/
JV> - Fix for JSFRI issue 162. FacesException should be thrown if
JV> illegal ValueExpression is passed to createComponent().
JV> - When setPropertyResolver() or setVariableResolver is invoked,
JV> no manipulation is required to satisfied the requirements for
JV> JSF 1.2. It is required only if decorator pattern is followed.


JV> - JSF RI 134. Synchronize on Application or SessionMap instead of
JV> locking on ApplicationAssociate.

Looks good.
JV> M src/com/sun/faces/config/
JV> - Remove DummyProperty/VariableImpl placed at the beginning of
JV> the legacy chain. This was causing the legacy resolvers
JV> following the decorator pattern to be not invoked.


JV> M src/com/sun/faces/util/
JV> log the exception when an adapter constructor is not found.

JV> M test/com/sun/faces/
JV> M test/com/sun/faces/
JV> M test/com/sun/faces/
JV> M test/com/sun/faces/application/
JV> M test/com/sun/faces/application/
JV> M web/test/WEB-INF/faces-config.xml
JV> Test case for decorator pattern and JSFRI 162.

Ok, r=edburns

|  | {home: 407 869 9587, office: 408 884 9519 OR x31640}
| homepage:         |
| aim: edburns0sunw | iim: