Hi Ed,
Minor logging related comment.
if ((null == (baseName = config[i].getBasename())) ||
+ (null == (var = config[i].getVar()))) {
+ String message = "Application ResourceBundle: null base-name or var." +
+ "base-name:" + config[i].getBasename() +
+ "var:" + config[i].getVar();
+ if (logger.isLoggable(Level.FINER)) {
+ logger.finer(message);
+ }
+ throw new IllegalArgumentException(message);
+ }
Could we use the log level "WARN" for the above so that it gets logged by default ? Also, could you please put a
pending comment to i18n messages with levels above "INFO" ? We'll have to revisit them later.
Looks good to me otherwise. r=jayashri
Thanks
-Jayashri
Ed Burns wrote:
>Can someone please review the change-bundle for this issue at
>
>https://javaserverfaces-spec-public.dev.java.net/issues/show_bug.cgi?id=82
>
>Ryan, I'd particularly appreciate your input on the changes to the
>schema.
>
>Thanks,
>
>Ed
>
>