dev@javaserverfaces.java.net

Re: Seeking Review - jsfapi 73

From: Adam Winer <adam.winer_at_oracle.com>
Date: Tue, 19 Jul 2005 10:07:35 -0700

There's no need to store the cause locally.
Throwable handles implementing getCause().
(IIRC, this glitch shows up elsewhere in the RI).

Also, the call to super() in:

     public ViewExpiredException(Throwable cause) {

         super(cause == null ? (String) null : cause.toString());
         this.cause = cause;

     }

... also redoes code that is in Throwable. So,
in the end, this should just be:


     public ViewExpiredException(Throwable cause) {
         super(cause);
     }


-- Adam


Roger Kitain wrote:
> Can someone review this?
>
> https://javaserverfaces-spec-public.dev.java.net/issues/show_bug.cgi?id=73
>
> -roger
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_javaserverfaces.dev.java.net
> For additional commands, e-mail: dev-help_at_javaserverfaces.dev.java.net
>