dev@javaserverfaces.java.net

Re: [REVIEW] Javadoc corrections

From: Roger Kitain <Roger.Kitain_at_Sun.COM>
Date: Wed, 22 Jun 2005 14:50:04 -0400

r=rogerk

Ryan Lubke wrote:

>
>
> SECTION: Modified Files
> ----------------------------
> M src/javax/faces/application/Application.java
> - corrected {_at_link} reference to RenderKit
> M src/javax/faces/component/ValueHolder.java
> - corrected language for getValue() (specifically
> the part if the local value is non-null return it,
> otherwise if non-null, check the valuebinding)
>
> SECTION: Diffs
> ----------------------------
> Index: src/javax/faces/application/Application.java
> ===================================================================
> RCS file:
> /cvs/javaserverfaces-sources/jsf-api/src/javax/faces/application/Application.java,v
>
> retrieving revision 1.34
> diff -u -r1.34 Application.java
> --- src/javax/faces/application/Application.java 17 Jun 2005
> 15:26:14 -0000 1.34
> +++ src/javax/faces/application/Application.java 22 Jun 2005
> 18:45:55 -0000
> @@ -156,12 +156,12 @@
>
> /**
> * <p>Set the <code>renderKitId</code> to be used to render this
> - * application. Unless the client has provided a custom {_at_link
> - * ViewHandler} that supports the use of multiple {_at_link RenderKit}
> - * instances in the same application, this method must only be
> called
> - * at application startup, before any Faces requests have been
> - * processed. This is a limitation of the current Specification,
> - * and may be lifted in a future release.</p>
> + * application. Unless the client has provided a custom {_at_link
> ViewHandler}
> + * that supports the use of multiple {_at_link
> javax.faces.render.RenderKit}
> + * instances in the same application, this method must only be
> called at
> + * application startup, before any Faces requests have been
> processed.
> + * This is a limitation of the current Specification, and may be
> lifted in
> + * a future release.</p>
> */
> public abstract void setDefaultRenderKitId(String renderKitId);
> Index: src/javax/faces/component/ValueHolder.java
> ===================================================================
> RCS file:
> /cvs/javaserverfaces-sources/jsf-api/src/javax/faces/component/ValueHolder.java,v
>
> retrieving revision 1.16
> diff -u -r1.16 ValueHolder.java
> --- src/javax/faces/component/ValueHolder.java 5 May 2005 20:51:05
> -0000 1.16
> +++ src/javax/faces/component/ValueHolder.java 22 Jun 2005 18:45:55
> -0000
> @@ -38,13 +38,12 @@
> /**
> * <p>Gets the value of this {_at_link UIComponent}. First, consult
> * the local value property of this component. If
> - * non-<code>null</code> return it. If non-null, see if we have a
> + * non-<code>null</code> return it. If <code>null</code>, see if
> we have a
> * {_at_link ValueExpression} for the <code>value</code> property. If
> * so, return the result of evaluating the property, otherwise
> - * return null. Note that because the specification for {_at_link
> + * return <code>null</code>. Note that because the specification
> for {_at_link
> * UIComponent#setValueBinding} requires a
> - * call through to {_at_link
> - * UIComponent#setValueExpression}, legacy
> + * call through to {_at_link UIComponent#setValueExpression}, legacy
> * tags will continue to work.</p>
> */
> public Object getValue();
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_javaserverfaces.dev.java.net
> For additional commands, e-mail: dev-help_at_javaserverfaces.dev.java.net
>