dev@javaserverfaces.java.net

Re: [REVIEW] Enable 'id' attribute to accept rtexprvalues

From: Jayashri Visvanathan <Jayashri.Visvanathan_at_Sun.COM>
Date: Wed, 18 May 2005 10:55:00 -0700

r=jayashri

Ryan Lubke wrote:

> SECTION: Modified Files
> ---------------------------------------
> M jsf-ri/conf/share/jsf-core.tld
> M jsf-tools/src/com/sun/faces/generate/JspTLD21Generator.java
> - set rtexprvalue property if the 'id' attribute to true
>
>
> SECTION: Diffs
> --------------------------------------
> Index: jsf-ri/conf/share/jsf_core.tld
> ===================================================================
> RCS file: /cvs/javaserverfaces-sources/jsf-ri/conf/share/jsf_core.tld,v
> retrieving revision 1.50
> diff -u -r1.50 jsf_core.tld
> --- jsf-ri/conf/share/jsf_core.tld 12 May 2005 22:08:14
> -0000 1.50
> +++ jsf-ri/conf/share/jsf_core.tld 18 May 2005 17:46:10 -0000
> @@ -522,7 +522,7 @@
> </description>
> <name>id</name>
> <required>false</required>
> - <rtexprvalue>false</rtexprvalue>
> + <rtexprvalue>true</rtexprvalue>
> </attribute>
>
> <attribute>
> @@ -613,7 +613,7 @@
> </description>
> <name>id</name>
> <required>false</required>
> - <rtexprvalue>false</rtexprvalue>
> + <rtexprvalue>true</rtexprvalue>
> </attribute>
>
> <attribute>
> @@ -705,7 +705,7 @@
> </description>
> <name>id</name>
> <required>false</required>
> - <rtexprvalue>false</rtexprvalue>
> + <rtexprvalue>true</rtexprvalue>
> </attribute>
>
> <attribute>
> @@ -753,7 +753,7 @@
> </description>
> <name>id</name>
> <required>true</required>
> - <rtexprvalue>false</rtexprvalue>
> + <rtexprvalue>true</rtexprvalue>
> </attribute>
>
> <attribute>
>
> Index: jsf-tools/src/com/sun/faces/generate/JspTLD21Generator.java
> ===================================================================
> RCS file:
> /cvs/javaserverfaces-sources/jsf-tools/src/com/sun/faces/generate/JspTLD21Generator.java,v
>
> retrieving revision 1.2
> diff -u -r1.2 JspTLD21Generator.java
> --- jsf-tools/src/com/sun/faces/generate/JspTLD21Generator.java 5 May
> 2005 20:51:39 -0000 1.2
> +++ jsf-tools/src/com/sun/faces/generate/JspTLD21Generator.java 18 May
> 2005 17:46:13 -0000
> @@ -55,8 +55,18 @@
>
> // -------------------------------------------------------
> Protected Methods
>
> + protected String getRtexprvalue(String tagName, String
> attributeName) {
>
> - /**
> + if ("id".equals(attributeName)) {
> + return "true";
> + } else {
> + return super.getRtexprvalue(tagName, attributeName);
> + }
> +
> + } // END getRtexprvalue
> +
> +
> + /**
> * The description element for this TLD.
> */
> protected void writeTldDescription() throws IOException {
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_javaserverfaces.dev.java.net
> For additional commands, e-mail: dev-help_at_javaserverfaces.dev.java.net
>