Re: [REVIEW] Return Converter and Validator test cases to running state; Findbugs corrections
r=jayashri
Ryan Lubke wrote:
>
> << ADD DESCRIPTION HERE >>
>
>
> SECTION: Modified Files
> ----------------------------
> jsf-tools
> -----------------
> M template-src/MessageFactory.java
> - coercion rules for String will result in null evaluation returning an
> empty string.
> Updated MessageFactory getLabel() and BindingFacesMessage to take this
> into account.
> These changes allow the ConverterTestCase to run as is.
>
> jsf-ri
> -----------------
> M src/com/sun/faces/RIConstants.java
> M src/com/sun/faces/application/ApplicationAssociate.java
> M src/com/sun/faces/application/ApplicationImpl.java
> M src/com/sun/faces/application/NavigationHandlerImpl.java
> M src/com/sun/faces/application/ViewHandlerResponseWrapper.java
> M src/com/sun/faces/config/ConfigureListener.java
> M src/com/sun/faces/config/ManagedBeanFactory.java
> M src/com/sun/faces/context/ExternalContextImpl.java
> M src/com/sun/faces/el/ManagedBeanELResolver.java
> M src/com/sun/faces/el/PropertyResolverChainWrapper.java
> M src/com/sun/faces/lifecycle/ApplyRequestValuesPhase.java
> M src/com/sun/faces/lifecycle/InvokeApplicationPhase.java
> M src/com/sun/faces/lifecycle/LifecycleFactoryImpl.java
> M src/com/sun/faces/lifecycle/ProcessValidationsPhase.java
> M src/com/sun/faces/lifecycle/RenderResponsePhase.java
> M src/com/sun/faces/lifecycle/RestoreViewPhase.java
> M src/com/sun/faces/lifecycle/UpdateModelValuesPhase.java
> M src/com/sun/faces/renderkit/ResponseStateManagerImpl.java
> M src/com/sun/faces/renderkit/html_basic/ButtonRenderer.java
> M src/com/sun/faces/renderkit/html_basic/CheckboxRenderer.java
> M src/com/sun/faces/renderkit/html_basic/CommandLinkRenderer.java
> M src/com/sun/faces/renderkit/html_basic/FormRenderer.java
> M src/com/sun/faces/renderkit/html_basic/GridRenderer.java
> M src/com/sun/faces/renderkit/html_basic/GroupRenderer.java
> M src/com/sun/faces/renderkit/html_basic/HtmlBasicInputRenderer.java
> M src/com/sun/faces/renderkit/html_basic/HtmlBasicRenderer.java
> M src/com/sun/faces/renderkit/html_basic/ImageRenderer.java
> M src/com/sun/faces/renderkit/html_basic/LabelRenderer.java
> M src/com/sun/faces/renderkit/html_basic/LinkRenderer.java
> M src/com/sun/faces/renderkit/html_basic/MenuRenderer.java
> M src/com/sun/faces/renderkit/html_basic/OutputLinkRenderer.java
> M src/com/sun/faces/renderkit/html_basic/TableRenderer.java
> M src/com/sun/faces/taglib/FacesValidator.java
> M src/com/sun/faces/taglib/html_basic/ColumnTag.java
> M src/com/sun/faces/taglib/jsf_core/ActionListenerTag.java
> M src/com/sun/faces/taglib/jsf_core/ValueChangeListenerTag.java
> M src/com/sun/faces/taglib/jsf_core/ViewTag.java
> - Change per findbugs (all pretty minor stuff)
> * removed unused variables and inner classes
> * made inner classes static nested classes
> * made serveral static Log fields private instead of protected
> * converted some string concatentation in loop over to StringBuffer
> * use of entrySet() vs keySet()
>
> M systest/build-tests.xml
> - removed ValidatorTestCase and ConverterTestCase from exclude list
>
> M systest/src/com/sun/faces/jsptest/ValidatorTestCase.java
> - updated the ID that is expected.
>
> SECTION: Diffs
> ----------------------------
> Index: template-src/MessageFactory.java
> ==