dev@javaserverfaces.java.net

Re: merge wta-head to jsf-head part one of four

From: Ed Burns <ed.burns_at_sun.com>
Date: Wed, 20 Apr 2005 16:58:25 -0700

>>>>> On Wed, 20 Apr 2005 16:34:17 -0700, Jayashri Visvanathan <Jayashri.Visvanathan_at_Sun.COM> said:

JV> Two comments:
JV> 1)

JV> M jsf-ri/src/com/sun/faces/context/ExternalContextImpl.java

JV> - NOTSURE:

JV> Use generic Maps as the type of the ivars.

JV> Use Collections.unmodifiableMap() where possible.

Do I have to roll back the changes to ExternalContext?

I know they're related to EL, but they don't have a compile time
dependency on it, and I'd like to do as much of the merging up front as
possible.

JV> Could you please roll back the above changes, because these are based on
JV> Unified EL and are not needed for TCCI.

JV> 2) Noticed some System.out.println statements in ViewHandlerImpl.

JV> Other than that, looks good to me. r=jayashri.

Thanks' I'll take those out.

Ed

-- 
| ed.burns_at_sun.com  | {home: 407 869 9587, office: 408 884 9519 OR x31640}
| homepage:         | http://purl.oclc.org/NET/edburns/
| aim: edburns0sunw | iim: ed.burns_at_sun.com