dev@javaserverfaces.java.net

Review: Remove Hidden/FormRenderer dependency

From: Jayashri Visvanathan <Jayashri.Visvanathan_at_Sun.COM>
Date: Mon, 14 Mar 2005 15:06:46 -0800

M src/com/sun/faces/renderkit/html_basic/HiddenRenderer.java
remove the dependecy between HiddenRenderer and FormRenderer.
HiddenRenderer.encodeEnd adds the hidden field its rendering to
FormRenderer but FormRenderer doesn't do anything with it.

All tests, demos(including standard demo) run.


Index: src/com/sun/faces/renderkit/html_basic/HiddenRenderer.java
===================================================================
RCS file: /cvs/javaserverfaces-sources/jsf-ri/src/com/sun/faces/renderkit/html_basic/HiddenRenderer.java,v
retrieving revision 1.21
diff -u -r1.21 HiddenRenderer.java
--- src/com/sun/faces/renderkit/html_basic/HiddenRenderer.java 12 Oct 2004 14:39:52 -0000 1.21
+++ src/com/sun/faces/renderkit/html_basic/HiddenRenderer.java 14 Mar 2005 23:01:31 -0000
@@ -97,8 +97,6 @@
             writer.writeAttribute("value", currentValue, "value");
         }
         writer.endElement("input");
-
- FormRenderer.addRenderedHiddenField(context, clientId);
     }
     
     // The testcase for this class is TestRenderers_3.java