Thanks for grabbing this issue so quickly. A couple of comments:
Jayashri Visvanathan wrote:
> Index: src/com/sun/faces/renderkit/html_basic/HtmlBasicRenderer.java
> ===================================================================
> RCS file: /cvs/javaserverfaces-sources/jsf-ri/src/com/sun/faces/renderkit/html_basic/HtmlBasicRenderer.java,v
> retrieving revision 1.88
> diff -u -r1.88 HtmlBasicRenderer.java
> --- src/com/sun/faces/renderkit/html_basic/HtmlBasicRenderer.java 14 Dec 2004 21:08:55 -0000 1.88
> +++ src/com/sun/faces/renderkit/html_basic/HtmlBasicRenderer.java 25 Feb 2005 02:07:12 -0000
> @@ -517,7 +517,7 @@
> } catch (IOException e) {
> if (log.isDebugEnabled()) {
> // PENDING I18N
> - log.debug("Can't write ID attribute" + e.getMessage());
> + log.debug("Can't write ID attribute" + e);
By appending the exception, you're adding the type of exception,
but still losing the stack trace. Better would be:
log.debug("Can't write ID attribute", e);
> @@ -1173,8 +1173,7 @@
> String msg = Util.getExceptionMessageString(
> Util.CANT_INSTANTIATE_CLASS_ERROR_MESSAGE_ID, params);
> if (log.isErrorEnabled()) {
> - log.error(msg + ":" + className + ":exception:" +
> - e.getMessage());
> + log.error(msg + ":" + className + ":exception:" + e);
And the same here:
log.error(msg + ":" + className, e);
Thanks,
Adam