dev@javaserverfaces.java.net

Re: [REVIEW] Issue 88 - Remove Shortcutting for Add/Subtract

From: Jacob Hookom <jacob_at_hookom.net>
Date: Tue, 08 Feb 2005 18:50:13 -0600

Tests ran successfully and changes have been committed, also added two
tests to TestELImpl.java (0+5 and 0-5)

Jayashri Visvanathan wrote:

> Looks good to me. r=jayashri.
> Please make sure all the unit tests continue to run.
> Thanks
> -Jayashri
>
> jacob_at_hookom.net wrote:
>
>> Summary:
>> https://javaserverfaces.dev.java.net/issues/show_bug.cgi?id=88
>>
>> Shortcutting for the add/subtract op was mistakenly added when the other
>> math ops were shortcutted for performance. This patch fixes the issue
>> for add/subtract for JSF. The EL-RI within WebTier alignment does not
>> have this mistake.
>>
>> Files Changed:
>> /cvs/javaserverfaces-sources/jsf-ri/src/com/sun/faces/el/impl/AbstractJsfParserVisitor.java
>>
>>
>> Diff:
>> Index: AbstractJsfParserVisitor.java
>> ===================================================================
>> RCS file:
>> /cvs/javaserverfaces-sources/jsf-ri/src/com/sun/faces/el/impl/AbstractJsfParserVisitor.java,v
>>
>> retrieving revision 1.2
>> diff -r1.2 AbstractJsfParserVisitor.java
>> 439,443d438
>> - Number num0 = coerceToNumber(obj0);
>> - if (num0.doubleValue() == 0.0)
>> - {
>> - return num0;
>> - }
>> 599,603d593
>> - Number num0 = coerceToNumber(obj0);
>> - if (num0.doubleValue() == 0.0)
>> - {
>> - return num0;
>> - }
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe_at_javaserverfaces.dev.java.net
>> For additional commands, e-mail: dev-help_at_javaserverfaces.dev.java.net
>>
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_javaserverfaces.dev.java.net
> For additional commands, e-mail: dev-help_at_javaserverfaces.dev.java.net
>
>


-- 
Jacob Hookom - Minneapolis
--------------------------
http://hookom.blogspot.com