Re: Review: Fix for Issue 63

From: Adam Winer <>
Date: Thu, 04 Nov 2004 15:39:49 -0800

One immediate issue is that the onclick code you add can't
just be appended to the user's, because a user might

   onclick="return runConfirmDialog();"

... where runConfirmDialog() returns true or false. This would
turn into generated output like:

   onclick="return runConfirmDialog(); clearHiddenParams_helloForm();"

... and clearHiddenParams_helloForm() would never get invoked.

Another issue added here is that commandButton now only works
inside of a UIForm. While it certainly is true that commandButton
can only work inside of an HTML <form>, this is adding a requirement
that the only component allowed to generate HTML <form>s are UIForm
components. This is, in fact, not the case - in ADF Faces, we
have a non-UIForm form component. You might be able to do some
Javascript work to go back from the <input type="submit">
(which is "this" in Javascript) to the <form> element.

-- Adam

Jayashri Visvanathan wrote:

> First iteration of fix based on Adam's comments attached here:
> Please review. Test updates to follow.
> Adam, I would appreciate if you can take a quick look
> Thanks a lot in advance
> -Jayashri
> ---------------------------------------------------------------------
> To unsubscribe, e-mail:
> For additional commands, e-mail:

To unsubscribe, e-mail:
For additional commands, e-mail: