Summary: Do not render "border" as attribute of "input" element
https://javaserverfaces.dev.java.net/issues/show_bug.cgi?id=24
M src/com/sun/faces/renderkit/html_basic/RadioRenderer.java
- exclude "border" pass through attribute
M web/test/RenderResponse_correct
- new golden file
Index: RadioRenderer.java
===================================================================
RCS file:
/cvs/javaserverfaces-sources/jsf-ri/src/com/sun/faces/renderkit/html_basic/RadioRenderer.java,v
retrieving revision 1.67
diff -u -r1.67 RadioRenderer.java
--- RadioRenderer.java 4 May 2004 19:55:08 -0000 1.67
+++ RadioRenderer.java 28 Jul 2004 16:29:54 -0000
@@ -126,7 +126,9 @@
// Apply HTML 4.x attributes specified on UISelectMany
component to all
// items in the list except styleClass and style which are
rendered as
// attributes of outer most table.
- Util.renderPassThruAttributes(writer, component, new
String[]{"style"});
+ Util.renderPassThruAttributes(writer, component,
+ new String[]{"style", "border"});
+
Util.renderBooleanPassThruAttributes(writer, component);
String itemLabel = curItem.getLabel();
Index: RenderResponse_correct
===================================================================
RCS file:
/cvs/javaserverfaces-sources/jsf-ri/web/test/RenderResponse_correct,v
retrieving revision 1.108
diff -u -r1.108 RenderResponse_correct
--- RenderResponse_correct 28 Jul 2004 14:52:14 -0000 1.108
+++ RenderResponse_correct 28 Jul 2004 16:30:38 -0000
@@ -15,7 +15,7 @@
-<form id="basicForm" method="post"
action="/test/faces/TestRenderResponsePhase.jsp;jsessionid=E23C981D7ED973CE2D826E7B53DB09B8"
class="formClass" accept-charset="some-charset" accept="html,wml"
enctype="application/x-www-form-urlencoded" title="basicForm">
+<form id="basicForm" method="post"
action="/test/faces/TestRenderResponsePhase.jsp;jsessionid=6E6598E4B463B472E7F9A6A3054DD3DF"
class="formClass" accept-charset="some-charset" accept="html,wml"
enctype="application/x-www-form-urlencoded" title="basicForm">
<TABLE BORDER="1">
@@ -130,12 +130,12 @@
- <a id="basicForm:imageLink" href="#" style="someStyle"
onclick="document.forms['basicForm']['basicForm:_idcl'].value='basicForm:imageLink';
document.forms['basicForm'].submit(); return false;"><img
src="duke.gif;jsessionid=E23C981D7ED973CE2D826E7B53DB09B8" alt="" /></a>
+ <a id="basicForm:imageLink" href="#" style="someStyle"
onclick="document.forms['basicForm']['basicForm:_idcl'].value='basicForm:imageLink';
document.forms['basicForm'].submit(); return false;"><img
src="duke.gif;jsessionid=6E6598E4B463B472E7F9A6A3054DD3DF" alt="" /></a>
</TD>
<TD>
- <img id="basicForm:graphicImage"
src="/test/duke.gif;jsessionid=E23C981D7ED973CE2D826E7B53DB09B8"
style="someStyle" usemap="#map1" ismap="ismap" alt="" />
+ <img id="basicForm:graphicImage"
src="/test/duke.gif;jsessionid=6E6598E4B463B472E7F9A6A3054DD3DF"
style="someStyle" usemap="#map1" ismap="ismap" alt="" />
</TD>
</TR>
@@ -169,7 +169,7 @@
- <a id="basicForm:hrefParamLink" href="#"
onclick="document.forms['basicForm']['basicForm:_idcl'].value='basicForm:hrefParamLink';document.forms['basicForm']['name'].value='horwat';document.forms['basicForm']['value'].value='password';
document.forms['basicForm'].submit(); return false;"><img
src="duke.gif;jsessionid=E23C981D7ED973CE2D826E7B53DB09B8" alt="" /></a>
+ <a id="basicForm:hrefParamLink" href="#"
onclick="document.forms['basicForm']['basicForm:_idcl'].value='basicForm:hrefParamLink';document.forms['basicForm']['name'].value='horwat';document.forms['basicForm']['value'].value='password';
document.forms['basicForm'].submit(); return false;"><img
src="duke.gif;jsessionid=6E6598E4B463B472E7F9A6A3054DD3DF" alt="" /></a>
</TD>
</TR>
@@ -177,7 +177,7 @@
<TD>
- <a id="basicForm:outputLink"
href="test.html;jsessionid=E23C981D7ED973CE2D826E7B53DB09B8"
class="hyperlinkClass">output link text</a>
+ <a id="basicForm:outputLink"
href="test.html;jsessionid=6E6598E4B463B472E7F9A6A3054DD3DF"
class="hyperlinkClass">output link text</a>
</TD>
@@ -189,12 +189,12 @@
- <a id="basicForm:output_imageLink"
href="test.html;jsessionid=E23C981D7ED973CE2D826E7B53DB09B8"
style="position: absolute; left: 96px; top: 168px"><img
src="duke.gif;jsessionid=E23C981D7ED973CE2D826E7B53DB09B8" alt="" /></a>
+ <a id="basicForm:output_imageLink"
href="test.html;jsessionid=6E6598E4B463B472E7F9A6A3054DD3DF"
style="position: absolute; left: 96px; top: 168px"><img
src="duke.gif;jsessionid=6E6598E4B463B472E7F9A6A3054DD3DF" alt="" /></a>
</TD>
<TD>
- <img id="basicForm:output_graphicImage"
src="/test/duke.gif;jsessionid=E23C981D7ED973CE2D826E7B53DB09B8"
usemap="#map1" ismap="ismap" alt="" />
+ <img id="basicForm:output_graphicImage"
src="/test/duke.gif;jsessionid=6E6598E4B463B472E7F9A6A3054DD3DF"
usemap="#map1" ismap="ismap" alt="" />
</TD>
</TR>
@@ -202,7 +202,7 @@
<TR>
<TD>
- <a id="basicForm:output_commandLink"
href="test.html;jsessionid=E23C981D7ED973CE2D826E7B53DB09B8"
style="position: absolute; left: 96px; top: 168px"
class="hyperlinkClass">link text</a>
+ <a id="basicForm:output_commandLink"
href="test.html;jsessionid=6E6598E4B463B472E7F9A6A3054DD3DF"
style="position: absolute; left: 96px; top: 168px"
class="hyperlinkClass">link text</a>
</TD>
</TR>
@@ -212,13 +212,13 @@
- <a id="basicForm:output_commandParamLink"
href="test.html;jsessionid=E23C981D7ED973CE2D826E7B53DB09B8?name=horwat&value=password"
class="hyperlinkClass">link text</a>
+ <a id="basicForm:output_commandParamLink"
href="test.html;jsessionid=6E6598E4B463B472E7F9A6A3054DD3DF?name=horwat&value=password"
class="hyperlinkClass">link text</a>
</TD>
</TR>
<TR>
<TD>
- <a id="basicForm:output_hrefLink"
href="test.html;jsessionid=E23C981D7ED973CE2D826E7B53DB09B8"><img
src="duke.gif"></a>
+ <a id="basicForm:output_hrefLink"
href="test.html;jsessionid=6E6598E4B463B472E7F9A6A3054DD3DF"><img
src="duke.gif"></a>
</TD>
</TR>
@@ -228,7 +228,7 @@
- <a id="basicForm:output_hrefParamLink"
href="test.html;jsessionid=E23C981D7ED973CE2D826E7B53DB09B8?name=horwat&value=password"><img
src="duke.gif;jsessionid=E23C981D7ED973CE2D826E7B53DB09B8" alt="" /></a>
+ <a id="basicForm:output_hrefParamLink"
href="test.html;jsessionid=6E6598E4B463B472E7F9A6A3054DD3DF?name=horwat&value=password"><img
src="duke.gif;jsessionid=6E6598E4B463B472E7F9A6A3054DD3DF" alt="" /></a>
</TD>
</TR>
@@ -414,15 +414,15 @@
<table border="1" id="basicForm:verticalRadio">
<tr>
<td>
-<label><input type="radio" name="basicForm:verticalRadio"
value="nextDay" disabled="disabled" border="1"> Next
Day</input></label></td>
+<label><input type="radio" name="basicForm:verticalRadio"
value="nextDay" disabled="disabled"> Next Day</input></label></td>
</tr>
<tr>
<td>
-<label><input type="radio" name="basicForm:verticalRadio"
value="nextWeek" border="1"> Next Week</input></label></td>
+<label><input type="radio" name="basicForm:verticalRadio"
value="nextWeek"> Next Week</input></label></td>
</tr>
<tr>
<td>
-<label><input type="radio" name="basicForm:verticalRadio"
value="nextMonth" border="1"> Next Month</input></label></td>
+<label><input type="radio" name="basicForm:verticalRadio"
value="nextMonth"> Next Month</input></label></td>
</tr>
</table>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_javaserverfaces.dev.java.net
For additional commands, e-mail: dev-help_at_javaserverfaces.dev.java.net