Summary: Id not rendered (OutputMessageRenderer)
https://javaserverfaces.dev.java.net/issues/show_bug.cgi?id=23
M src/com/sun/faces/renderkit/html_basic/OutputMessageRenderer.java
- write out id in span
M web/test/CorrectRenderersResponse_2
M web/test/RenderResponse_correct
- new golden files
M web/test/TestRenderResponsePhase.jsp
- include outputFormat for test
ndex: OutputMessageRenderer.java
===================================================================
RCS file:
/cvs/javaserverfaces-sources/jsf-ri/src/com/sun/faces/renderkit/html_basic/OutputMessageRenderer.java,v
retrieving revision 1.14
diff -u -r1.14 OutputMessageRenderer.java
--- OutputMessageRenderer.java 31 Mar 2004 18:48:38 -0000 1.14
+++ OutputMessageRenderer.java 28 Jul 2004 13:32:56 -0000
@@ -159,6 +159,7 @@
Util.hasPassThruAttributes(component) ||
shouldWriteIdAttribute(component)) {
writer.startElement("span", component);
+ writeIdAttributeIfNecessary(context, writer, component);
wroteSpan = true;
if (null != styleClass) {
Index: CorrectRenderersResponse_2
===================================================================
RCS file:
/cvs/javaserverfaces-sources/jsf-ri/web/test/CorrectRenderersResponse_2,v
retrieving revision 1.35
diff -u -r1.35 CorrectRenderersResponse_2
--- CorrectRenderersResponse_2 11 Jun 2004 20:14:55 -0000 1.35
+++ CorrectRenderersResponse_2 28 Jul 2004 13:33:38 -0000
@@ -8,4 +8,4 @@
</select>
<input id="mySecret" type="password" name="mySecret" value="" />
<input id="myInputText" type="text" name="myInputText" value="text"
/><span id="myOutputText"></span><textarea id="myTextarea"
name="myTextarea" class="bar" style="foo">TextareaRenderer</textarea>
-<img id="myGraphicImage"
src="/test/nonModelReferenceImage.gif;jsessionid=6F464B3D8C1EA6D3913CF768D6179A6E"
usemap="usemap" ismap="ismap" alt="" /><img
src="/test/foo/modelReferenceImage.gif;jsessionid=6F464B3D8C1EA6D3913CF768D6179A6E"
usemap="usemap" ismap="ismap" alt="" /><span>My name is Bobby Orr</span>
\ No newline at end of file
+<img id="myGraphicImage"
src="/test/nonModelReferenceImage.gif;jsessionid=8D63DB48224D7D53305A9DCFB57F587D"
usemap="usemap" ismap="ismap" alt="" /><img
src="/test/foo/modelReferenceImage.gif;jsessionid=8D63DB48224D7D53305A9DCFB57F587D"
usemap="usemap" ismap="ismap" alt="" /><span id="myOutputMessage">My
name is Bobby Orr</span>
\ No newline at end of file
Index: RenderResponse_correct
===================================================================
RCS file:
/cvs/javaserverfaces-sources/jsf-ri/web/test/RenderResponse_correct,v
retrieving revision 1.107
diff -u -r1.107 RenderResponse_correct
--- RenderResponse_correct 27 Jul 2004 19:59:59 -0000 1.107
+++ RenderResponse_correct 28 Jul 2004 13:33:39 -0000
@@ -15,7 +15,7 @@
-<form id="basicForm" method="post"
action="/test/faces/TestRenderResponsePhase.jsp;jsessionid=1FA4AE40978CAEAD1EB29E903EE13A3F"
class="formClass" accept-charset="some-charset" accept="html,wml"
enctype="application/x-www-form-urlencoded" title="basicForm">
+<form id="basicForm" method="post"
action="/test/faces/TestRenderResponsePhase.jsp;jsessionid=E23C981D7ED973CE2D826E7B53DB09B8"
class="formClass" accept-charset="some-charset" accept="html,wml"
enctype="application/x-www-form-urlencoded" title="basicForm">
<TABLE BORDER="1">
@@ -130,12 +130,12 @@
- <a id="basicForm:imageLink" href="#" style="someStyle"
onclick="document.forms['basicForm']['basicForm:_idcl'].value='basicForm:imageLink';
document.forms['basicForm'].submit(); return false;"><img
src="duke.gif;jsessionid=1FA4AE40978CAEAD1EB29E903EE13A3F" alt="" /></a>
+ <a id="basicForm:imageLink" href="#" style="someStyle"
onclick="document.forms['basicForm']['basicForm:_idcl'].value='basicForm:imageLink';
document.forms['basicForm'].submit(); return false;"><img
src="duke.gif;jsessionid=E23C981D7ED973CE2D826E7B53DB09B8" alt="" /></a>
</TD>
<TD>
- <img id="basicForm:graphicImage"
src="/test/duke.gif;jsessionid=1FA4AE40978CAEAD1EB29E903EE13A3F"
style="someStyle" usemap="#map1" ismap="ismap" alt="" />
+ <img id="basicForm:graphicImage"
src="/test/duke.gif;jsessionid=E23C981D7ED973CE2D826E7B53DB09B8"
style="someStyle" usemap="#map1" ismap="ismap" alt="" />
</TD>
</TR>
@@ -169,7 +169,7 @@
- <a id="basicForm:hrefParamLink" href="#"
onclick="document.forms['basicForm']['basicForm:_idcl'].value='basicForm:hrefParamLink';document.forms['basicForm']['name'].value='horwat';document.forms['basicForm']['value'].value='password';
document.forms['basicForm'].submit(); return false;"><img
src="duke.gif;jsessionid=1FA4AE40978CAEAD1EB29E903EE13A3F" alt="" /></a>
+ <a id="basicForm:hrefParamLink" href="#"
onclick="document.forms['basicForm']['basicForm:_idcl'].value='basicForm:hrefParamLink';document.forms['basicForm']['name'].value='horwat';document.forms['basicForm']['value'].value='password';
document.forms['basicForm'].submit(); return false;"><img
src="duke.gif;jsessionid=E23C981D7ED973CE2D826E7B53DB09B8" alt="" /></a>
</TD>
</TR>
@@ -177,7 +177,7 @@
<TD>
- <a id="basicForm:outputLink"
href="test.html;jsessionid=1FA4AE40978CAEAD1EB29E903EE13A3F"
class="hyperlinkClass">output link text</a>
+ <a id="basicForm:outputLink"
href="test.html;jsessionid=E23C981D7ED973CE2D826E7B53DB09B8"
class="hyperlinkClass">output link text</a>
</TD>
@@ -189,12 +189,12 @@
- <a id="basicForm:output_imageLink"
href="test.html;jsessionid=1FA4AE40978CAEAD1EB29E903EE13A3F"
style="position: absolute; left: 96px; top: 168px"><img
src="duke.gif;jsessionid=1FA4AE40978CAEAD1EB29E903EE13A3F" alt="" /></a>
+ <a id="basicForm:output_imageLink"
href="test.html;jsessionid=E23C981D7ED973CE2D826E7B53DB09B8"
style="position: absolute; left: 96px; top: 168px"><img
src="duke.gif;jsessionid=E23C981D7ED973CE2D826E7B53DB09B8" alt="" /></a>
</TD>
<TD>
- <img id="basicForm:output_graphicImage"
src="/test/duke.gif;jsessionid=1FA4AE40978CAEAD1EB29E903EE13A3F"
usemap="#map1" ismap="ismap" alt="" />
+ <img id="basicForm:output_graphicImage"
src="/test/duke.gif;jsessionid=E23C981D7ED973CE2D826E7B53DB09B8"
usemap="#map1" ismap="ismap" alt="" />
</TD>
</TR>
@@ -202,7 +202,7 @@
<TR>
<TD>
- <a id="basicForm:output_commandLink"
href="test.html;jsessionid=1FA4AE40978CAEAD1EB29E903EE13A3F"
style="position: absolute; left: 96px; top: 168px"
class="hyperlinkClass">link text</a>
+ <a id="basicForm:output_commandLink"
href="test.html;jsessionid=E23C981D7ED973CE2D826E7B53DB09B8"
style="position: absolute; left: 96px; top: 168px"
class="hyperlinkClass">link text</a>
</TD>
</TR>
@@ -212,13 +212,13 @@
- <a id="basicForm:output_commandParamLink"
href="test.html;jsessionid=1FA4AE40978CAEAD1EB29E903EE13A3F?name=horwat&value=password"
class="hyperlinkClass">link text</a>
+ <a id="basicForm:output_commandParamLink"
href="test.html;jsessionid=E23C981D7ED973CE2D826E7B53DB09B8?name=horwat&value=password"
class="hyperlinkClass">link text</a>
</TD>
</TR>
<TR>
<TD>
- <a id="basicForm:output_hrefLink"
href="test.html;jsessionid=1FA4AE40978CAEAD1EB29E903EE13A3F"><img
src="duke.gif"></a>
+ <a id="basicForm:output_hrefLink"
href="test.html;jsessionid=E23C981D7ED973CE2D826E7B53DB09B8"><img
src="duke.gif"></a>
</TD>
</TR>
@@ -228,7 +228,7 @@
- <a id="basicForm:output_hrefParamLink"
href="test.html;jsessionid=1FA4AE40978CAEAD1EB29E903EE13A3F?name=horwat&value=password"><img
src="duke.gif;jsessionid=1FA4AE40978CAEAD1EB29E903EE13A3F" alt="" /></a>
+ <a id="basicForm:output_hrefParamLink"
href="test.html;jsessionid=E23C981D7ED973CE2D826E7B53DB09B8?name=horwat&value=password"><img
src="duke.gif;jsessionid=E23C981D7ED973CE2D826E7B53DB09B8" alt="" /></a>
</TD>
</TR>
@@ -840,6 +840,11 @@
<TABLE>
<span title="output text with title">should be spanned</span>
+
+
+
+<span id="basicForm:userMsg">Param 0: my param</span>
+
<input type="hidden" name="basicForm" value="basicForm" /><input
type="hidden" name="value" /><input type="hidden" name="basicForm:_idcl"
/><input type="hidden" name="name" /></form>
Index: TestRenderResponsePhase.jsp
===================================================================
RCS file:
/cvs/javaserverfaces-sources/jsf-ri/web/test/TestRenderResponsePhase.jsp,vretrieving
revision 1.81
diff -u -r1.81 TestRenderResponsePhase.jsp
--- TestRenderResponsePhase.jsp 27 Jul 2004 19:59:59 -0000 1.81
+++ TestRenderResponsePhase.jsp 28 Jul 2004 13:33:40 -0000
@@ -772,6 +772,11 @@
<h:outputText title="output text with title" value="should be spanned" />
+<h:outputFormat id="userMsg" value="Param 0: {0}" >
+ <f:param value="my param"/>
+</h:outputFormat>
+
+
</h:form>
</f:view>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_javaserverfaces.dev.java.net
For additional commands, e-mail: dev-help_at_javaserverfaces.dev.java.net