>>>>> On Tue, 17 Jan 2017 18:23:50 -0500, Leonardo Uribe <leonardo.uribe_at_irian.at> said:
LU> I just wanted to comment that the idea is allow use keywords in
LU> "targets" attribute. In MyFaces the change worked well. But this is
LU> a minor feature of the search expression API, so in the worst case,
LU> the changes related to AttachedObjectTargetImpl can be reverted
LU> without significant impact. The two main use cases where this API is
LU> used are f:ajax and h:outputLabel.
2017-01-17 21:24 GMT-05:00 Edward Burns <edward.burns_at_oracle.com>:
EB> Thanks for your input. So you are saying that the feature as
EB> currently implemented allows the targets attribute in composite
EB> components to contain search keywords?
>>>>> On Wed, 18 Jan 2017 00:29:09 -0500, Leonardo Uribe <leonardo.uribe_at_irian.at> said:
LU> Yes, that's the idea. It would be nice, but the problem here is the
LU> algorithm for composite components can conflict with this feature
LU> (even if I have not found a conflicting case yet).
>>>>> On Wed, 18 Jan 2017 09:09:36 +0100, Thomas Andraschko <andraschko.thomas_at_gmail.com> said:
TA> Yep, for me it's also ok to just revert the AttachedObjectTargetImpl
TA> changes as the major changes are in h:outputLabel, h:message(s) and
TA> f:ajax.
TA> I also checked the unit tests but the strange this is: The
TA> SearchExpressionHandler is called one time and the found component
TA> is the same as without my changes.
Ok, that's what I did. I just reverted AttachedObjectTargetImpl and
removed the @Ignore that I added.
Let's see if this is clean on Hudson. It was clean locally.
Ed
--
| edward.burns_at_oracle.com | office: +1 407 458 0017
| 4 business days until planned start of JSF 2.3 Public Review
| 24 business days until DevNexus 2017
| 49 business days until JavaLand 2017