Hi
Here is my review. I did it as complete as possible. Thanks for provide the
links.
- Multi-field Validation <f:validateWholeBean />
I feel unconfortable about this:
"... This tag must be placed in the component tree after all of the fields
that are to be included in the multi-field validation. If this precondition
is not met, the results of applying this tag are unspecified. ..."
It is clear the reason of the statement: before the validation it is
necessary to be sure that all fields have their values assigned.
But it would be better if the validation is done as part of the parent
UIForm instance. If there is an input component, there is always an UIForm
instance in the component hierarchy. It sounds better to "subscribe" a
component instance to the parent UIForm (an special facet for UIForm? or an
special "validator" attached object?).
It is also not clear what happens when an ajax request is performed. Please
note <f:validateWholeBean /> does not have an id, but there is a underlying
UIInput instance mentioned in the javadoc. The problem is if by coincidence
the UIInput instance is inside a part that does some partial validation,
the validation code will be activated, even if the request performs a
partial validation over the form.
- ui:repeat supports Map and Iterable
UIData javadoc does not mention anything. IterableDataModel does not
mention anything too.
The relevant section that should be updated in the spec is
UIData.getValue() to include java.util.Map and IterableDataMode
- DataModel implementations can be registered
Annotation javadoc of FacesDataModel is ok, but where is the javadoc that
describe how a UIData instance uses the DataModel? Again some documentation
on UIData.getValue() is required (use
getFacesContext().getApplication().... to do some magic).
- Add “disabled” attribute for h:button
Added but not marked in orange color.
- Document UIData.setRowStatePreserved() in VDLDoc and Render
Kit Doc
ui:repeat does not still have rowStatePreserved like UIData (it should!).
(why UIRepeat is not part of javax.faces.component package?).
regards,
Leonardo Uribe
2015-10-08 16:23 GMT-05:00 Edward Burns <edward.burns_at_oracle.com>:
> >>>>> On Thu, 8 Oct 2015 12:44:31 -0500, Josh Juneau <juneau001_at_gmail.com>
> said:
>
> JJ> Thanks to everyone for the great work on this release, and for the JSF
> JJ> specification as a whole. It is great to have followed the
> specification
> JJ> from its infancy to its current maturity.
>
> JJ> I have only briefly reviewed the EDR pdf thus far, but I thought it
> would
> JJ> be good to mention that some of the embedded JIRA links are not
> JJ> functional. I know that all of the JIRA links do work, in fact, if
> they
> JJ> are manually added into the browser. However, some of the links that
> JJ> contain multiple issue numbers separated by a comma are not clickable,
> JJ> whereas others that contain multiple issue numbers work fine and bring
> up
> JJ> the first issue in the list when clicked. It seems that a space is
> required
> JJ> after each comma in order for the initial issue link in the list to
> JJ> function properly.
>
> Thanks for the feedback. I'm going to let that one slide!
>
> JJ> I will continue to review the document...everything else looks great so
> JJ> far. Thanks again for putting this together, and to everyone for their
> JJ> continued work and dedication to JSF.
>
> Also, Manfred released 2.3.0-m04 today!
>
> Ed
>
> --
> | edward.burns_at_oracle.com | office: +1 407 458 0017
> | 21 Business days til JavaOne 2015
> | 36 Business days til DOAG 2015
>