users@javaserverfaces-spec-public.java.net

[jsr372-experts mirror] [jsr372-experts] Re: Re: Adopt-a-JSR Help: serialVersionUID in spec classes and Mojarra impl

From: Bauke Scholtz <balusc_at_gmail.com>
Date: Fri, 30 Jan 2015 15:21:31 +0100

It adds the compiler-generated one. So, technically, it makes the hidden
auto-generated one visible.

Cheers, B

On Fri, Jan 30, 2015 at 3:16 PM, manfred riem <manfred.riem_at_oracle.com>
wrote:

> Hi Bauke,
>
> Just to make sure, does it generate one, or does it make the hidden
> auto-generated one visible?
>
> Thanks!
> Manfred
>
>
> On 1/30/15, 7:35 AM, Bauke Scholtz wrote:
>
> Eclipse can take care of this in only a few clicks.
>
> The affected classes are outlined in the following commits:
> javax.faces.*:
> https://github.com/omnifaces/mojarra/commit/7c8edf6ddd63d92f34ff00014d7cf9e92372894b
> com.sun.faces.*:
> https://github.com/omnifaces/mojarra/commit/8294362d8cede72546804d85344bdae745beee88
>
> Cheers, B
>
>
> On Fri, Jan 30, 2015 at 2:14 PM, <edward.burns_at_oracle.com> wrote:
>
>> Hello Volunteers,
>>
>> A busywork task has emerged that is best addressed in a comprehensive
>> matter spanning the spec and Mojarra implementation classes. Briefly,
>> we have been inconsistent in our application of serialVersionUID, and
>> the time has come to be consistent. I'm going to try to leverage the
>> Adopt-a-JSR program to do this work. To that end, I have written up
>> the
>> task on our Adopt-a-JSR tab at < https://jcp.org/en/egc/view?id=372 >.
>> Here is the relevant text:
>>
>> We have inconsistently applied the serialVersionUID class variable to
>> spec and impl of JSF in Mojarra. The community could really help by
>> filing JIRAs and submitting patches against them. This is pretty much
>> busywork, but is very necessary. This work could proceed in several
>> phases:
>>
>> Identify which classes need to be touched. Technically only those
>> classes that will be serialized need have a serialVersionUID. With
>> JSF, this is actually a lot of classes because of the statefulness of
>> JSF and the support for clustering.
>>
>> File JIRAs for the work. I suggest the JIRAs be filed per Java
>> package. The Mojarra JIRA <
>> https://java.net/jira/browse/JAVASERVERFACES > must be used here,
>> even
>> though there is a spec impact. Once the task gets rolling, the spec
>> leads will file an appropriate spec JIRA. Here is the list of Java
>> classes in the spec and Mojarra impl.
>>
>> jsf-api/src/main/java/javax/faces
>> jsf-api/src/main/java/javax/faces/application
>> jsf-api/src/main/java/javax/faces/bean
>> jsf-api/src/main/java/javax/faces/component
>> jsf-api/src/main/java/javax/faces/component/behavior
>> jsf-api/src/main/java/javax/faces/component/html
>> jsf-api/src/main/java/javax/faces/component/visit
>> jsf-api/src/main/java/javax/faces/context
>> jsf-api/src/main/java/javax/faces/convert
>> jsf-api/src/main/java/javax/faces/el
>> jsf-api/src/main/java/javax/faces/event
>> jsf-api/src/main/java/javax/faces/flow
>> jsf-api/src/main/java/javax/faces/flow/builder
>> jsf-api/src/main/java/javax/faces/lifecycle
>> jsf-api/src/main/java/javax/faces/model
>> jsf-api/src/main/java/javax/faces/render
>> jsf-api/src/main/java/javax/faces/validator
>> jsf-api/src/main/java/javax/faces/view
>> jsf-api/src/main/java/javax/faces/view/facelets
>> jsf-api/src/main/java/javax/faces/webapp
>> jsf-ri/src/main/java/com/sun/faces
>> jsf-ri/src/main/java/com/sun/faces/action
>> jsf-ri/src/main/java/com/sun/faces/application
>> jsf-ri/src/main/java/com/sun/faces/application/annotation
>> jsf-ri/src/main/java/com/sun/faces/application/resource
>> jsf-ri/src/main/java/com/sun/faces/application/view
>> jsf-ri/src/main/java/com/sun/faces/component
>> jsf-ri/src/main/java/com/sun/faces/component/behavior
>> jsf-ri/src/main/java/com/sun/faces/component/validator
>> jsf-ri/src/main/java/com/sun/faces/component/visit
>> jsf-ri/src/main/java/com/sun/faces/config
>> jsf-ri/src/main/java/com/sun/faces/config/configprovider
>> jsf-ri/src/main/java/com/sun/faces/config/processor
>> jsf-ri/src/main/java/com/sun/faces/context
>> jsf-ri/src/main/java/com/sun/faces/context/flash
>> jsf-ri/src/main/java/com/sun/faces/el
>> jsf-ri/src/main/java/com/sun/faces/ext
>> jsf-ri/src/main/java/com/sun/faces/ext/component
>> jsf-ri/src/main/java/com/sun/faces/ext/render
>> jsf-ri/src/main/java/com/sun/faces/ext/taglib
>> jsf-ri/src/main/java/com/sun/faces/ext/validator
>> jsf-ri/src/main/java/com/sun/faces/facelets
>> jsf-ri/src/main/java/com/sun/faces/facelets/compiler
>> jsf-ri/src/main/java/com/sun/faces/facelets/component
>> jsf-ri/src/main/java/com/sun/faces/facelets/el
>> jsf-ri/src/main/java/com/sun/faces/facelets/impl
>> jsf-ri/src/main/java/com/sun/faces/facelets/tag
>> jsf-ri/src/main/java/com/sun/faces/facelets/tag/composite
>> jsf-ri/src/main/java/com/sun/faces/facelets/tag/jsf
>> jsf-ri/src/main/java/com/sun/faces/facelets/tag/jsf/core
>> jsf-ri/src/main/java/com/sun/faces/facelets/tag/jsf/html
>> jsf-ri/src/main/java/com/sun/faces/facelets/tag/jstl
>> jsf-ri/src/main/java/com/sun/faces/facelets/tag/jstl/core
>> jsf-ri/src/main/java/com/sun/faces/facelets/tag/jstl/fn
>> jsf-ri/src/main/java/com/sun/faces/facelets/tag/ui
>> jsf-ri/src/main/java/com/sun/faces/facelets/util
>> jsf-ri/src/main/java/com/sun/faces/flow
>> jsf-ri/src/main/java/com/sun/faces/flow/builder
>> jsf-ri/src/main/java/com/sun/faces/io
>> jsf-ri/src/main/java/com/sun/faces/lifecycle
>> jsf-ri/src/main/java/com/sun/faces/mgbean
>> jsf-ri/src/main/java/com/sun/faces/renderkit
>> jsf-ri/src/main/java/com/sun/faces/renderkit/html_basic
>> jsf-ri/src/main/java/com/sun/faces/scripting
>> jsf-ri/src/main/java/com/sun/faces/scripting/groovy
>> jsf-ri/src/main/java/com/sun/faces/spi
>> jsf-ri/src/main/java/com/sun/faces/taglib
>> jsf-ri/src/main/java/com/sun/faces/taglib/html_basic
>> jsf-ri/src/main/java/com/sun/faces/taglib/jsf_core
>> jsf-ri/src/main/java/com/sun/faces/util
>> jsf-ri/src/main/java/com/sun/faces/util/cdi11
>> jsf-ri/src/main/java/com/sun/faces/vendor
>>
>> Please help with this task if you can.
>>
>> Thanks,
>>
>> Ed
>>
>
>