users@javaserverfaces-spec-public.java.net

[jsr344-experts mirror] [jsr344-experts] [949-ClientWindow] Leonardo: thanks and please review

From: Edward Burns <edward.burns_at_oracle.com>
Date: Wed, 31 Oct 2012 08:37:20 -0700

>>>>> On Wed, 24 Oct 2012 23:26:48 -0500, Leonardo Uribe <lu4242_at_gmail.com> said:

LU> Hi
LU> I have checked the documentation related to ClientWindow feature and I have
LU> some observations to do.

Let me spell out the list of changes I plan to make as a result of your
20121024 2326 email. Leonardo, please confirm that:

a) I have listed all the required changes.

b) The sense of each change is correct.

ACTION: Leonardo, please reply by COB tomorrow, 20121101, sooner if
possible.

* Change the javadoc of ResponseStateManager.WINDOW_ID_URL_PARAM to
  reflect the fact that the "mode" concept is not coupled with the
  presence or absence of information in the URL related to client
  window.

* Rename the disable/enable/is methods in ClientWindow as you suggest:-

LU> static void disableClientWindowRenderMode(FacesContext context)
LU> static void enableClientWindowRenderMode(FacesContext context)
LU> static boolean isClientWindowRenderModeEnabled(FacesContext context)

* Add a method to ClientWindow

LU> public Map<String, String> getQueryUrlParameters(FacesContext
  context)

  The sense of the method is that it provides a way for custom
  ClientWindow impls to get their information into the URL and have 100%
  faith that it will be there in all possible cases when a URL is
  generated. The default impl will return null and will be specified as
  such.

  Make sure to update any of the methods anywhere that mention putting
  information in the URL related to client window to require the calling
  of this method. Do this in the spec and the impl.

Thanks,

Ed

-- 
| edward.burns_at_oracle.com | office: +1 407 458 0017
| homepage:               | http://ridingthecrest.com/