Yep, for me it's also ok to just revert the AttachedObjectTargetImpl
changes as the major changes are in h:outputLabel, h:message(s) and f:ajax.
I also checked the unit tests but the strange this is:
The SearchExpressionHandler is called one time and the found component is
the same as without my changes.
2017-01-18 6:29 GMT+01:00 Leonardo Uribe <leonardo.uribe_at_irian.at>:
>
>
> 2017-01-17 21:24 GMT-05:00 Edward Burns <edward.burns_at_oracle.com>:
>
>> >>>>> On Tue, 17 Jan 2017 18:23:50 -0500, Leonardo Uribe <
>> leonardo.uribe_at_irian.at> said:
>>
>> LU> I just wanted to comment that the idea is allow use keywords in
>> "targets"
>> LU> attribute. In MyFaces the change worked well.
>>
>> LU> But this is a minor feature of the search expression API, so in the
>> worst
>> LU> case, the changes related to AttachedObjectTargetImpl can be reverted
>> LU> without significant impact. The two main use cases where this API is
>> used
>> LU> are f:ajax and h:outputLabel.
>>
>> Thanks for your input. So you are saying that the feature as currently
>> implemented allows the targets attribute in composite components to
>> contain search keywords?
>>
>>
> Yes, that's the idea. It would be nice, but the problem here is the
> algorithm
> for composite components can conflict with this feature (even if I have not
> found a conflicting case yet).
>
> regards,
>
> Leonardo Uribe
>
>
>> Ed
>>
>> --
>> | edward.burns_at_oracle.com | office: +1 407 458 0017
>> | 5 business days until planned start of JSF 2.3 Public Review
>> | 25 business days until DevNexus 2017
>> | 50 business days until JavaLand 2017
>>
>
>