jsr372-experts@javaserverfaces-spec-public.java.net

[jsr372-experts] Re: [SPEC-1238] request for review (was: Re: [PROPOSAL] CDI integration for UIComponent instances in JSF 2.3)

From: Edward Burns <edward.burns_at_oracle.com>
Date: Sun, 15 Jan 2017 23:11:23 -0800

>>>>> On Sat, 14 Jan 2017 22:31:50 +0100, Bauke Scholtz <balusc_at_gmail.com> said:

BalusC> This is a bug in the test itself. The <h:outputLabel for="test">
BalusC> is wrong. There doesn't exist a component with id="text".

BalusC> You have 2 options:
BalusC> 1. Fix the test.
BalusC> 2. Change EXPRESSION_HINTS of LabelRenderer to add IGNORE_NO_RESULT.

BalusC> I recommend 2. This is namely not required in HTML side.

Yes, Thomas recommended a similar approach. That's what I did.

EB> <<< FAILURE! - in com.sun.faces.test.servlet30.facelets.Issue3152IT

This was also an erroneous test. The ids of the "render" attribute of
f:ajax are comma separated, not space separated. Nonetheless, I still
opted to keep the test unchanged and had it fall back to the old
behavior. See AjaxBehaviorRenderer.

I have committed this now as 3ab4cf8. I really hope this doesn't break
the tree!

Ed

-- 
| edward.burns_at_oracle.com | office: +1 407 458 0017
|  6 business days until planned start of JSF 2.3 Public Review
| 26 business days until DevNexus 2017
| 51 business days until JavaLand 2017