jsr372-experts@javaserverfaces-spec-public.java.net

[jsr372-experts] Re: 1070 Add ExternalContext#setFlash(Flash) method

From: manfred riem <manfred.riem_at_oracle.com>
Date: Thu, 12 Jan 2017 14:18:39 -0700

Hi Neil,

I prefer NOT to uptake this change as in my view the Flash should be
simplified and rewritten using CDI in a subsequent version of the
specification.

But if Ed gives it his OK I am OK with it.

Thanks!

Kind regards.
Manfred Riem


On 1/12/17, 2:01 PM, Neil Griffin wrote:
> Hi Ed, Manfred,
>
> We've got a commit ready with a fix for this, including a test.
>
> May we push the commit and close JAVASERVERFACES_SPEC_PUBLIC-1070?
>
> Thanks,
>
> Neil
>
>> On Jan 10, 2017, at 5:35 PM, Neil Griffin<neil.griffin_at_portletfaces.org> wrote:
>>
>> @Ed: Just found this one in my email. Somehow the fixVersion is no longer set to 2.3:
>> https://java.net/jira/browse/JAVASERVERFACES_SPEC_PUBLIC-1070
>>
>> I can get this done by tomorrow if you would permit me. Let me know, thanks.
>>
>>> On Mar 20, 2013, at 5:37 PM, Edward Burns<edward.burns_at_oracle.com> wrote:
>>>
>>>>>>>> On Thu, 20 Dec 2012 15:30:47 -0500, Neil Griffin<neil.griffin_at_portletfaces.org> said:
>>> NG> Hello Volunteers,
>>> NG> ExternalContext has a method named getFlash() [1] but there is no corresponding setFlash(Flash) method.
>>>
>>> NG> In order to achieve the goal of "portlet as first class citizen" in
>>> NG> JSF 2.2, I created issue 1070 [2] as a proposal to add the method.
>>>
>>> NG> I respectfully ask for your consideration and support.
>>>
>>> I'm very sorry Neil, but I was not able to get this in for 2.2. I've
>>> set the fixVersion to be 2.3.
>>>
>>> Ed
>>>
>